-
Notifications
You must be signed in to change notification settings - Fork 0
홈화면 고도화 #77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
홈화면 고도화 #77
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
74f3c22
Merge pull request #73 from project-lyrics/dev
elive7 629fe07
Merge pull request #74 from project-lyrics/dev
elive7 8a540ac
Merge pull request #75 from project-lyrics/dev
elive7 e530164
Merge pull request #76 from project-lyrics/dev
elive7 57beee1
fix : 검색 결과 순서대로 반환하도록 수정
elive7 e8f9e83
[SCRUM-261] feat: Note에 ENUM 타입 컬럼 'type' 추가
9d261eb
[SCRUM-261] feat: NoLyricsForNoteException 추가
924bde4
[SCRUM-261] feat: NoteCreate.validateLyricsForType 추가하여 가사 해석 노트임에도 가…
c2fe276
[SCRUM-261] fix: 사용자의 노트 검색 API의 URI를 /api/v1/notes -> /api/v1/users/…
7de4faa
[SCRUM-261] fix: getNotesOfFavoriteArtists -> getNotes 수정
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
31 changes: 31 additions & 0 deletions
31
src/main/java/com/projectlyrics/server/domain/note/entity/NoteType.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| package com.projectlyrics.server.domain.note.entity; | ||
|
|
||
| import com.fasterxml.jackson.annotation.JsonCreator; | ||
| import com.fasterxml.jackson.annotation.JsonValue; | ||
| import lombok.RequiredArgsConstructor; | ||
|
|
||
| import java.util.Arrays; | ||
|
|
||
| @RequiredArgsConstructor | ||
| public enum NoteType { | ||
|
|
||
| FREE("FREE"), | ||
| QUESTION("QUESTION"), | ||
| LYRICS_ANALYSIS("LYRICS_ANALYSIS"), | ||
| ; | ||
|
|
||
| private final String type; | ||
|
|
||
| @JsonValue | ||
| public String getType() { | ||
| return type; | ||
| } | ||
|
|
||
| @JsonCreator | ||
| public static NoteType of(String type) { | ||
| return Arrays.stream(NoteType.values()) | ||
| .filter(noteType -> noteType.type.equals(type)) | ||
| .findFirst() | ||
| .orElseThrow(() -> new IllegalArgumentException("Invalid NoteType: " + type)); | ||
| } | ||
| } |
11 changes: 11 additions & 0 deletions
11
src/main/java/com/projectlyrics/server/domain/note/exception/NoLyricsForNoteException.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| package com.projectlyrics.server.domain.note.exception; | ||
|
|
||
| import com.projectlyrics.server.domain.common.message.ErrorCode; | ||
| import com.projectlyrics.server.global.exception.FeelinException; | ||
|
|
||
| public class NoLyricsForNoteException extends FeelinException { | ||
|
|
||
| public NoLyricsForNoteException() { | ||
| super(ErrorCode.NO_LYRICS_FOR_NOTE); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/user로 시작하는데도 NoteController에 적은 이유가 따로 있나요? 수정을 할 필요는 없을 것 같은데 궁금해요