Skip to content

Conversation

@rquidute
Copy link
Contributor

@rquidute rquidute commented Dec 18, 2025

What changed

This PR improves the way to run the test_run_execution command by adding a sort ordering functionality and the possibility to retrieve all test run execution records. Also it was added project-id filtering capability.

  • Default Sort Behavior: Changed CLI default to use descending order (--sort desc) to show newest test runs first
  • New --all Flag: Added --all option that fetches all test run executions with screen pagination (similar to git log)
  • Enhanced Filter Display: Implemented comprehensive, color-coded filter information showing active parameters (order, skip, limit, results scope)
  • Added --project-id / -p option to filter test runs by project ID
  • Parameter Validation: Added validation to prevent incompatible flag combinations (--all with --limit, --log with pagination options)
  • Improved Help Text: Updated help messages to clarify default values and parameter relationships

Related Issue

project-chip/certification-tool#823

Testing

  • Unit tests added and passing
Screenshot 2025-12-17 at 17 42 35
  • Added active filter header and pagination
Screenshot 2025-12-17 at 17 40 49
  • Using project-id filter
Screenshot 2025-12-23 at 10 54 46
  • Command example using sort
Screenshot 2025-12-17 at 17 40 33
  • Command example using sort
Screenshot 2025-12-17 at 17 40 18

@rquidute rquidute self-assigned this Dec 18, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @rquidute, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the test_run_execution command-line interface by introducing robust sorting capabilities and an option to fetch all test run records with integrated pagination. It also improves user feedback by displaying active filters and adds crucial validation to prevent conflicting command-line arguments, making the tool more intuitive and powerful for managing test run data.

Highlights

  • Enhanced CLI Functionality: The test_run_execution command now supports sorting of results and an option to retrieve all records with screen pagination.
  • Default Sort Order: The default sort behavior for test_run_execution has been changed to descending order (--sort desc), displaying the newest test runs first.
  • New --all Flag: A new --all flag has been introduced, allowing users to fetch all test run executions, presented with screen pagination similar to git log.
  • Improved Filter Display: The command output now includes comprehensive, color-coded filter information, clearly showing active parameters such as order, skip, limit, and results scope.
  • Parameter Validation: Validation has been added to prevent incompatible flag combinations, specifically disallowing --all with --limit, and --log with pagination or sorting options.
  • API Update: The underlying API for retrieving test run executions (read_test_run_executions_api_v1_test_run_executions_get) has been updated to accept a sort_order parameter.
  • New Unit Tests: New unit tests have been added to cover the --sort and --all functionalities, as well as the validation of incompatible flag combinations.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces several valuable enhancements to the test_run_execution command, including default sorting, an --all flag for fetching all records, and improved user feedback on active filters. The implementation is solid, and the new features significantly improve the command's usability. I've added a few review comments with suggestions for improving code clarity, consistency, and validation logic. Specifically, I've pointed out an area for simplifying the filter display logic, a more idiomatic way to handle Pydantic models, and a point of confusion in the command-line argument validation. I also noticed a couple of missing assertions in the new tests to ensure resource cleanup is consistently verified. Overall, this is a great contribution.

rquidute and others added 6 commits December 18, 2025 17:01
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@antonio-amjr
Copy link
Contributor

antonio-amjr commented Dec 23, 2025

@rquidute This image from description it's showing the table header "State" misaligned with the actual data.
Is it like that still or is it fixed?

528288718-0e58aa35-cae0-4afa-b26c-957074661ef7

Copy link
Contributor

@antonio-amjr antonio-amjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider the below:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants