-
Notifications
You must be signed in to change notification settings - Fork 4
Fix test_run_execution command #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v2.15-cli-develop
Are you sure you want to change the base?
Fix test_run_execution command #52
Conversation
Summary of ChangesHello @rquidute, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces several valuable enhancements to the test_run_execution command, including default sorting, an --all flag for fetching all records, and improved user feedback on active filters. The implementation is solid, and the new features significantly improve the command's usability. I've added a few review comments with suggestions for improving code clarity, consistency, and validation logic. Specifically, I've pointed out an area for simplifying the filter display logic, a more idiomatic way to handle Pydantic models, and a point of confusion in the command-line argument validation. I also noticed a couple of missing assertions in the new tests to ensure resource cleanup is consistently verified. Overall, this is a great contribution.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
@rquidute This image from description it's showing the table header "State" misaligned with the actual data.
|
antonio-amjr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please consider the below:

What changed
This PR improves the way to run the test_run_execution command by adding a sort ordering functionality and the possibility to retrieve all test run execution records. Also it was added project-id filtering capability.
Related Issue
project-chip/certification-tool#823
Testing