Repository navigation
Reintegrate 0.14.0 release metadata into main - #16
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Reviewer's GuideReintegrates the v0.14.0 release entry and updates Rust metadata, runtime version reporting, HTTP identification, and embedded/standalone C sources to match the release while preserving ABI version 1; review the exact older-branch diff and run CI, but do not tag or publish a release. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="src/runtime/http.c" line_range="522" />
<code_context>
}
if (!has_ua) {
- buf_append(&req, "User-Agent: flint/0.7.0\r\n", 25);
+ buf_append(&req, "User-Agent: flint/0.14.0\r\n", strlen("User-Agent: flint/0.14.0\r\n"));
}
if (!has_accept) {
</code_context>
<issue_to_address>
**HTTPS requests use curl identity**
When an HTTPS request does not provide its own User-Agent, `curl_fetch` forwards only caller-provided headers to curl and never adds the new default, so HTTPS requests use curl’s default User-Agent instead of identifying Flint to the server.
Add the Flint default User-Agent to `curl_fetch` when the caller has not supplied one, and keep the embedded copy in sync.
Also at `rust/flintlang/c-src/src/runtime/http.c:522`.
</issue_to_address>Sourcery assessment
Approval pending. 1 finding to address first.
Blocking findings: src/runtime/http.c:522
| } | ||
| if (!has_ua) { | ||
| buf_append(&req, "User-Agent: flint/0.7.0\r\n", 25); | ||
| buf_append(&req, "User-Agent: flint/0.14.0\r\n", strlen("User-Agent: flint/0.14.0\r\n")); |
There was a problem hiding this comment.
🟡 Medium · HTTPS requests use curl identity
When an HTTPS request does not provide its own User-Agent, curl_fetch forwards only caller-provided headers to curl and never adds the new default, so HTTPS requests use curl’s default User-Agent instead of identifying Flint to the server.
Add the Flint default User-Agent to curl_fetch when the caller has not supplied one, and keep the embedded copy in sync.
Also at rust/flintlang/c-src/src/runtime/http.c:522.
Prompt for AI agents
In `src/runtime/http.c` at line 522:
**HTTPS requests use curl identity**
When an HTTPS request does not provide its own User-Agent, `curl_fetch` forwards only caller-provided headers to curl and never adds the new default, so HTTPS requests use curl’s default User-Agent instead of identifying Flint to the server.
Add the Flint default User-Agent to `curl_fetch` when the caller has not supplied one, and keep the embedded copy in sync.
Also at `rust/flintlang/c-src/src/runtime/http.c:522`.
Recovery PR: the original #12 is marked merged, but the current main tree still lacks the v0.14.0 release entry and release metadata. This branch is older than main, so review the exact diff and run CI before merging; do not tag or publish a release as part of this PR.
Summary by Sourcery
Reintegrate the v0.14.0 release metadata and version alignment into the main branch without publishing release artifacts.
Enhancements:
Documentation:
Chores: