Repository navigation
Prepare 0.14.0 release metadata #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
6ab109b
75cf9a7
682932a
e37c5ae
2f77438
ae82d9d
cf03a4d
72e44d7
a6409f8
150480f
94ff375
f219b2c
12534cc
039c6a3
fc016a5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -519,7 +519,7 @@ static char *socket_fetch(const Url *u, | |
| buf_append(&req, hbuf, strlen(hbuf)); | ||
| } | ||
| if (!has_ua) { | ||
| buf_append(&req, "User-Agent: flint/0.7.0\r\n", 25); | ||
| buf_append(&req, "User-Agent: flint/0.14.0\r\n", strlen("User-Agent: flint/0.14.0\r\n")); | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🟡 Medium · HTTPS omits Flint User-Agent When an HTTPS request has no explicit User-Agent header, Add the same default Flint User-Agent to the HTTPS curl arguments in both runtime copies. Also at Prompt for AI agentsIn `src/runtime/http.c` at line 522:
**HTTPS omits Flint User-Agent**
When an HTTPS request has no explicit User-Agent header, `http_request_native` dispatches HTTPS to `curl_fetch`, whose curl arguments do not add a Flint User-Agent; HTTPS requests therefore identify as curl rather than `flint/0.14.0`.
Add the same default Flint User-Agent to the HTTPS curl arguments in both runtime copies.
Also at `rust/flintlang/c-src/src/runtime/http.c:522`. |
||
| } | ||
| if (!has_accept) { | ||
| buf_append(&req, "Accept: */*\r\n", 13); | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚪ Low · Rust guide shows stale release
When readers consult the Rust guide for the 0.14.0 crate version,
docs/rust.mdstill identifies the Rust crate as tracking 0.13.0, so it gives outdated release information and conflicts with the README's 0.14.0 guidance.Update
docs/rust.mdto say the Rust crate tracks version 0.14.0.Also at
rust/flintlang/README.md:47.Prompt for AI agents