Skip to content

fixed order_by - like_diff #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
petrCher merged 1 commit into from
Apr 28, 2026
Merged

fixed order_by - like_diff #169

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 13 additions & 12 deletions rating_api/models/db.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ def like_count(self):
def like_count(cls):
"""SQL выражение для подсчета лайков"""
return (
select(func.count(CommentReaction.uuid))
select(func.coalesce(func.count(CommentReaction.uuid), 0))
.where(and_(CommentReaction.comment_uuid == cls.uuid, CommentReaction.reaction == Reaction.LIKE))
.label('like_count')
)
Expand All @@ -211,7 +211,7 @@ def dislike_count(self):
def dislike_count(cls):
"""SQL выражение для подсчета дизлайков"""
return (
select(func.count(CommentReaction.uuid))
select(func.coalesce(func.count(CommentReaction.uuid), 0))
.where(and_(CommentReaction.comment_uuid == cls.uuid, CommentReaction.reaction == Reaction.DISLIKE))
.label('dislike_count')
)
Expand All @@ -228,12 +228,15 @@ def like_dislike_diff(cls):
"""SQL выражение для вычисления разницы лайков/дизлайков"""
return (
select(
func.sum(
case(
(CommentReaction.reaction == Reaction.LIKE, 1),
(CommentReaction.reaction == Reaction.DISLIKE, -1),
else_=0,
)
func.coalesce(
func.sum(
case(
(CommentReaction.reaction == Reaction.LIKE, 1),
(CommentReaction.reaction == Reaction.DISLIKE, -1),
else_=0,
)
),
0,
)
)
.where(CommentReaction.comment_uuid == cls.uuid)
Expand All @@ -243,10 +246,8 @@ def like_dislike_diff(cls):
@hybrid_method
def order_by_like_diff(cls, asc_order: bool = False):
"""Метод для сортировки по разнице лайков/дизлайков"""
if asc_order:
return cls.like_dislike_diff.asc()
else:
return cls.like_dislike_diff.desc()
# Primary ordering: like-dislike diff (coalesced to 0)
return cls.like_dislike_diff.asc() if asc_order else cls.like_dislike_diff.desc()

@hybrid_method
def has_reaction(self, user_id: int, react: Reaction) -> bool:
Expand Down
Loading