Skip to content

Fix XEP-0388 continue child declaration order - #112

Merged
badlop merged 1 commit into
processone:masterfrom
rallep71:fix/xep0388-continue-order
Aug 27, 2026
Merged

Fix XEP-0388 continue child declaration order#112
badlop merged 1 commit into
processone:masterfrom
rallep71:fix/xep0388-continue-order

Conversation

@rallep71

Copy link
Copy Markdown
Contributor

The XEP-0388 schema defines the children of continue in this order:

  1. additional-data
  2. tasks
  3. text

xmpp_codec.spec currently declares additional-data, text, tasks. This
patch moves tasks before text so that the source specification matches the
schema.

This is separate from the reference-group ordering problem in fast_xml,
which is addressed by processone/fast_xml#53. Both corrections are
needed for the generated XEP-0388 codec to emit the expected order.

I have not edited the generated codec. The repository's contribution guidance
asks contributors not to commit generated files, and the full regeneration
should in any case use the fast_xml change accepted upstream.

Related to processone/ejabberd#4606.

Testing

I tested this with the pinned xmpp 1.13.4 and fast_xml 1.1.60 sources. The stock
codec serialises continue as text, tasks, additional-data. With the
generator and specification fixes applied, it serialises as
additional-data, tasks, text.

@p1bot

p1bot commented Aug 24, 2026

Copy link
Copy Markdown
Collaborator

Hi @rallep71, many thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

@p1bot p1bot added the cla-missing Contributor needs to sign Contribution License Agreement label Aug 24, 2026
@p1bot

p1bot commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator

You did it @rallep71!

Thank you for signing the ProcessOne Contribution License Agreement.

We will have a look at your contribution!

@p1bot p1bot removed the cla-missing Contributor needs to sign Contribution License Agreement label Aug 27, 2026
@badlop
badlop merged commit b690439 into processone:master Aug 27, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants