Fix XEP-0388 continue child declaration order - #112
Merged
Conversation
Collaborator
|
Hi @rallep71, many thanks for your contribution! In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. |
Collaborator
|
You did it @rallep71! Thank you for signing the ProcessOne Contribution License Agreement. We will have a look at your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The XEP-0388 schema defines the children of
continuein this order:additional-datataskstextxmpp_codec.speccurrently declaresadditional-data,text,tasks. Thispatch moves
tasksbeforetextso that the source specification matches theschema.
This is separate from the reference-group ordering problem in
fast_xml,which is addressed by processone/fast_xml#53. Both corrections are
needed for the generated XEP-0388 codec to emit the expected order.
I have not edited the generated codec. The repository's contribution guidance
asks contributors not to commit generated files, and the full regeneration
should in any case use the
fast_xmlchange accepted upstream.Related to processone/ejabberd#4606.
Testing
I tested this with the pinned xmpp 1.13.4 and fast_xml 1.1.60 sources. The stock
codec serialises
continueastext, tasks, additional-data. With thegenerator and specification fixes applied, it serialises as
additional-data, tasks, text.