WIP: Add visual regression tests (to be split into focused PRs)#1460
WIP: Add visual regression tests (to be split into focused PRs)#1460khuntvidisha13 wants to merge 5 commits intoprocessing:visual-testingfrom
Conversation
…ranslate, rotate, scale, pushpop)
… blend, mode reset)
|
Hello @khuntvidisha13! Thank you for your efforts, I'd like to leave a few comments on your PR. Have you tried opening an issue first indicating the actually behavior, or missing test you found? It really helps maintainers understand the context and whether the approach fits the project's direction. It also gives a place to discuss the test structure before a lot of code is written. Maintainers will have better guidance on how to approach this. I'd recommend open one issue proposing visual regression testing as a concept, and get maintainer take :) |
|
Hello @khuntvidisha13 , just additional to what @dpoppe7 said, in my experience in professional settings, ideally, PRs are organized to make reviews intuitive and easy to do by someone who isn't familiar with the edits. Think about how to structure the PR in a way that is intuitive to someone new to the code - I assure you, PRs will be approved much faster that way. Also, it makes it easier for you yourself to review the code, and find unwanted regressions. |
|
Thank you @mingness! I am new to open source so I was not aware of the proper process and I will make sure to follow the guidelines going forward. I will break this PR into smaller ones. Should I close this first? |
What this PR does
Adds visual regression tests for basic Processing primitive shapes:
How it works
Each test creates a baseline screenshot on first run and compares against it on subsequent runs.
Related
Extends the visual testing framework introduced in the visual-testing branch.