Skip to content

Commit 1b137e2

Browse files
committed
remove getCodeIndex() after all (resolves #596)
1 parent 1aec7d8 commit 1b137e2

File tree

2 files changed

+14
-14
lines changed

2 files changed

+14
-14
lines changed

app/src/processing/app/Sketch.java

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1764,23 +1764,14 @@ public int getCodeCount() {
17641764
}
17651765

17661766

1767+
// Used by GUI Builder for Processing
1768+
// https://github.com/processing/processing4/issues/545
1769+
// https://github.com/processing/processing4/issues/596
17671770
public SketchCode getCode(int index) {
17681771
return code[index];
17691772
}
17701773

17711774

1772-
// Cannot remove because this is used by GUI Builder for Processing
1773-
// https://github.com/processing/processing4/issues/545
1774-
public int getCodeIndex(SketchCode who) {
1775-
for (int i = 0; i < codeCount; i++) {
1776-
if (who == code[i]) {
1777-
return i;
1778-
}
1779-
}
1780-
return -1;
1781-
}
1782-
1783-
17841775
public SketchCode getCurrentCode() {
17851776
return current;
17861777
}

todo.txt

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@ X fix potential casting problem with Platform and DefaultPlatform
44
X should be unreachable, but fixed anyway
55
X bring back getCodeIndex() for GUI Builder Tool
66
X https://github.com/processing/processing4/issues/545
7+
X ...and remove again
8+
X https://github.com/processing/processing4/issues/596
79

810
contribs
911
X Catalan translation for Processing 4.0.1
@@ -30,8 +32,8 @@ before 4.0.2
3032
X library version number parsing isn't ignoring comments properly
3133
X https://github.com/processing/processing4/issues/586
3234
X https://github.com/processing/processing4/issues/553
33-
_ Can't Update Libraries due to "this.progressBar" is null error message
34-
_ https://github.com/processing/processing4/issues/567
35+
X Can't Update Libraries due to "this.progressBar" is null error message
36+
X https://github.com/processing/processing4/issues/567
3537
_ if naming scheme produces a sketch w/ the same name, what happens?
3638
_ probably a crash (or infinite loop?) need to check
3739
_ temp folders owned by one user can't be overwritten by another
@@ -47,6 +49,12 @@ _ https://github.com/processing/processing4/issues/548
4749
_ a report that theme is not being kept after Processing restart on Windows
4850
_ https://github.com/processing/processing4/issues/565
4951

52+
_ if user clicks "no" when asked to access Documents folder, will cause weird problems later
53+
_ "Please fix read/write" in ContributionManager.updateFlagged()
54+
_ but that also shouldn't prevent users from continuing
55+
_ https://github.com/processing/processing4/issues/581
56+
_ use tccutil or some api to check whether user has disallowed access
57+
5058
_ preproc inserting weird number of spaces
5159
_ before 'public' in functions, it's an extra single space
5260
_ not indenting the rest of the code at all
@@ -157,6 +165,7 @@ _ https://github.com/processing/processing4/wiki/Preferences#proxies
157165
_ right-click/ctrl-click for jump to declaration causes hang
158166
_ https://github.com/processing/processing4/issues/527
159167
_ https://github.com/processing/processing4/issues/551
168+
_ https://github.com/processing/processing4/issues/595
160169

161170
design
162171
_ completion mode pop-up not following dark and light mode conventions

0 commit comments

Comments
 (0)