fix null progress bar "Updates" tab in Contributions Manager (resolves #567)

Author: benfry

app/src/processing/app/contrib/StatusDetail.java

@@ -166,11 +166,16 @@ protected void update() {
       // For the special "Updates" tab in the manager, there are no progress
       // bars, so if that's what we're doing, this will create a dummy bar.
       // TODO Not a good workaround [fry 220312]
-//      if (progressBar == null) {
-//        initProgressBar();
-//      }
-      progressBar.setVisible(true);
-      progressBar.setIndeterminate(true);
+      // TODO This is really, really gross [fry 221104]
+      if (progressBar == null) {
+        // This was removed in 4.x and brought back for 4.0.2 because
+        // it broke the "Update All" option in the Contributions Manager.
+        // https://github.com/processing/processing4/issues/567
+        progressBar = new JProgressBar();
+      } else {
+        progressBar.setVisible(true);
+        progressBar.setIndeterminate(true);
+      }
 
       ContribProgress progress = new ContribProgress(progressBar) {
         @Override

todo.txt

@@ -357,6 +357,8 @@ _ when adding a new library, its examples aren't added to the list until restart
 
 PDE / Manager (4.x notes)
 
+_ get rid of dummy progress bar being created in StatusDetail.update()
+_   would be good to *add* a progress bar of some kind, but sheesh
 _ remove dorky loading.gif (used in ContributionTab and UpdateContributionTab)
 _   should be a better way to implement this
 _ if no internet available, install buttons disabled, but not clear why broken