Fix/fes warnings glsl keywords 9038

[skyyash]

Resolves #9038

Changes:

1. walk through ast and check for isStrandsBuildersCall.
2. add callback body ranges to strandsBodyRanges using recordCallbackBody.
3. find if node isInsideStrands.
4. include insideStrands in variables and functions of userDefinitions.
5. warn when builtInGLSLFunctions keywords used insideStrands.
6. added tests to test/unit/core/sketch_overrides.js.

PR Checklist

• npm run lint passes

• Inline reference is included / updated

• Unit tests are included / updated

[p5-bot]

Continuous Release

CDN link

• https://raw.esm.sh/pr/p5@b5ca533/lib/p5.min.js

Published Packages

• https://pkg.pr.new/p5@b5ca533

Commit hash: b5ca533

Previous deployments

0de494e

• https://raw.esm.sh/pr/p5@0de494e/lib/p5.min.js
• https://pkg.pr.new/p5@0de494e

---

This is an automated message.

[davepagurek]

Do you think we should add a condition to this checking that the .modify() is called on a base*Shader call? Just thinking that modify on its own may be a bit too far-reaching

[skyyash]

makes sense! done

[davepagurek]

Nice work on this! Just one minor case I left a comment for, after that itll be good to go!

[perminder-17]

I think the !Object.hasOwn(builtInGLSLFunctions, name) guard here causes a regression. Names like max, floor, sin, abs, sqrt are both p5 globals and GLSL builtins, so with this guard a top-level function max() {} outside of any strands callback no longer triggers the existing p5 conflict warning (it did on main), and the new strands loop below skips it too since insideStrands is false.

So, we can remove this !Object.hasOwn(builtInGLSLFunctions, name), wdyt?

[skyyash]

hmm. removing it will make warning appear for common functions but will cause warnings for strands identifers like length used outside strands block... lemme think

[skyyash]

@perminder-17 we can create a new variable to store strandsAddedP5Globals, names strands adds to p5.prototype but were not original p5 globals. then skip only those in loop 1, so outside length stays silent while outside max still warns. loop 2 keeps the full builtin list, so inside max and length both warn. what do you think?

earlier i thought of using this pattern (const isp5Function = overrides[0].isp5Function;) used in src/strands/strands_api.js but then i realized that flag does not mean the same thing. It means p5 has something similar, not the same name on (eg, for distance its true but p5 has dist not distance)