Add support for negative vertex indices in OBJ loader for 2.x#8512
Open
avinxshKD wants to merge 1 commit intoprocessing:dev-2.0from
Open
Add support for negative vertex indices in OBJ loader for 2.x#8512avinxshKD wants to merge 1 commit intoprocessing:dev-2.0from
avinxshKD wants to merge 1 commit intoprocessing:dev-2.0from
Conversation
avinxshKD
force-pushed
the
fix/obj-negative-indices-2.0
branch
from
a6043fc to
3d1f4d6
Compare
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switched OBJ face parsing to use
.at()for array access instead of bracket notation. Negative indices (like -1 for last vertex) now work per OBJ spec, positive indices still get converted from 1-based to 0-based.Resolves #8493
Changes
src/webgl/loading.js.at()forloadedVerts.v,loadedVerts.vt,loadedVerts.vnlookups to handle both negative and positive indexingtest/unit/assets/cube-negative-indices.obj,, test file with negative face indicesPR Checklist