Skip to content

Fix Show actual type in strands hook error messages#8505

Open
Anshumancanrock wants to merge 2 commits intoprocessing:dev-2.0from
Anshumancanrock:fix-undefined-bug
Open

Fix Show actual type in strands hook error messages#8505
Anshumancanrock wants to merge 2 commits intoprocessing:dev-2.0from
Anshumancanrock:fix-undefined-bug

Conversation

@Anshumancanrock
Copy link

Resolves #8444

Changes:

  • Fixed bug: retNode.baseTypereturnedNode.baseType (was causing "undefined" instead of actual type)
  • Error messages now show the actual returned type (e.g., "vec4" instead of "undefined")
  • Struct mismatch error now lists expected properties so users know what the struct contains
  • Added guidance explaining users should modify and return the input struct
  • Improved incomplete struct error to show expected vs received properties

PR Checklist

Copy link
Contributor

@davepagurek davepagurek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this on! Would you be able to add some unit tests for this? A strategy could be to spy on FES.userError (search for spy in the tests directory for examples) and assert that it was called with the expected message.

@Anshumancanrock Anshumancanrock force-pushed the fix-undefined-bug branch 3 times, most recently from a1af831 to c875874 Compare February 8, 2026 23:26
@Anshumancanrock
Copy link
Author

@davepagurek Done! Added unit tests with vi.mock on strands_FES , covers all three error paths (wrong type in struct hook, vector dimension mismatch, incomplete struct).

Please take a look and let me know if you would like any changes. Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants