Fix Show actual type in strands hook error messages#8505
Open
Anshumancanrock wants to merge 2 commits intoprocessing:dev-2.0from
Open
Fix Show actual type in strands hook error messages#8505Anshumancanrock wants to merge 2 commits intoprocessing:dev-2.0from
Anshumancanrock wants to merge 2 commits intoprocessing:dev-2.0from
Conversation
davepagurek
reviewed
Feb 8, 2026
Contributor
davepagurek
left a comment
There was a problem hiding this comment.
Thanks for taking this on! Would you be able to add some unit tests for this? A strategy could be to spy on FES.userError (search for spy in the tests directory for examples) and assert that it was called with the expected message.
a1af831 to
c875874
Compare
c875874 to
a8871c3
Compare
Author
|
@davepagurek Done! Added unit tests with Please take a look and let me know if you would like any changes. Thanks ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #8444
Changes:
retNode.baseType→returnedNode.baseType(was causing "undefined" instead of actual type)PR Checklist
npm run lintpasses