Improve Accessibility Guidance for describe() Usage (#8101)
#8247
+54
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add fontWidth() and clarify textWidth vs fontWidth docs in attributes.js * updated as per maintainers comment, only documentation is updated * Add fontWidth() and clarify textWidth vs fontWidth docs in attributes.js; simple docs are updated, not code * aded docs for difference between textWidth and fontWidth with respect to whitespace * unnecesaary file introduced, removed it, cleanedup the thing i was supposed to do * docs updated as asked * removed things from previous pr * i think done, if not will ask maintainer * check, merge conflicts * updated the docs as per suggesstion from perminder * fixes as per review * updated the bad code and good code examples, so actually now can diffrentiated b/w them * fix:inverted comma typos * invert typos * invert typos * invert typos * invert typos * invert typos * invert typos * invert typos * invert typos * invert typos * invert typos * invert typos * invert typos * invert typos * invert typos * invert typos * invert typos * invert typos * invert typos * invert typos to do fix * invert typos to do fix * invert typos to do fix * invert typos to do fix * invert typos to do fix * invert typos to do fix * invert typos to do fix * invert typos to do fix * invert typos to do fix * invert typos to do fix * invert typos to do fix * invert typos to do fix * invert typos to do fix * had docs style section repeated, removed to resolve redundancy * Tidy web accessibility updates * Tidy updates to documentation style guide * Tidy documentation style guide table of contents * Tidy web accessibility references in contributor docs * Tidy contributing documentation for describe() * Tidy unintended change in textCore.js * Update contributor_docs/documentation_style_guide.md --------- Co-authored-by: kit <1304340+ksen0@users.noreply.github.com> Co-authored-by: Perminder Singh <127239756+perminder-17@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies #8101 to
mainbranch as well asdev-2.0, as it is applicable in both instances.Fixes #6387