Skip to content

Add Chinese translation for repeating-with-loops.mdx#1206

Merged
ksen0 merged 4 commits intoprocessing:mainfrom
Theresa-Em:translate-loops-zh
Mar 3, 2026
Merged

Add Chinese translation for repeating-with-loops.mdx#1206
ksen0 merged 4 commits intoprocessing:mainfrom
Theresa-Em:translate-loops-zh

Conversation

@Theresa-Em
Copy link
Contributor

@Theresa-Em Theresa-Em commented Mar 1, 2026

Summary

This PR adds a full Chinese (zh-CN) translation of the Loops tutorial.

Notes

Addresses #1151

@Theresa-Em Theresa-Em closed this Mar 1, 2026
@Theresa-Em Theresa-Em force-pushed the translate-loops-zh branch from 4f0908c to 0e72ceb Compare March 1, 2026 23:03
@Theresa-Em Theresa-Em deleted the translate-loops-zh branch March 1, 2026 23:07
@Theresa-Em Theresa-Em restored the translate-loops-zh branch March 1, 2026 23:14
@Theresa-Em Theresa-Em reopened this Mar 1, 2026
Copy link
Contributor

@lirenjie95 lirenjie95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Theresa-Em, thank you very much for your contribution! I have finished the code review, and overall, your translation is great. I've noted a few minor typos for you to revise. I've also shared some suggestions regarding a few expressions that read somewhat awkwardly—please feel free to review them, and I'd be happy to discuss these points with you further.

PS: this PR addresses #1151.

@Theresa-Em
Copy link
Contributor Author

Hi @lirenjie95,
Thank you for the review! I’ve addressed all the feedback. The PR has been updated. Looking forward to your next review.

Copy link
Contributor

@lirenjie95 lirenjie95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good job!

@ksen0
Copy link
Member

ksen0 commented Mar 2, 2026

Thanks so much for all your work on this @Theresa-Em @lirenjie95 !

Question - I noticed that this translation includes both English and Chinese title/headings, but an existing one does not: https://beta.p5js.org/zh-hans/tutorials/get-started/

I think English titles and headings should not be included; or if they are then they should be included everywhere for consistency. What do you think? Also cc @Divyansh013 regarding general translation guidelines

@lirenjie95
Copy link
Contributor

lirenjie95 commented Mar 3, 2026

@ksen0 Hi Kit, thank you so much for the thoughtful advice. I'm the author of the Chinese translation of the "get-started" tutorial, so I'd be happy to share some perspective on this. For beginners from diverse backgrounds—especially those with different language proficiencies—I want to ensure that English doesn't become a barrier to learning. That's why I translated the headings and titles into Chinese. There are also two other PRs (#1202 #1192) for Chinese translations that follow the same principle.

Given this, I'd like to suggest removing the English portion and keeping only the Chinese text for headings/titles. This would provide a cleaner, more accessible experience for Chinese-speaking learners.

@Theresa-Em I'd love to hear any comments or thoughts you might have on this approach!

@Divyansh013
Copy link
Member

Thanks @Theresa-Em for your work! Aside hi @ksen0 @lirenjie95 , I believe the english titles are already there in English version of website and to maintain consistency we can avoid the same in translated languages.

@ksen0
Copy link
Member

ksen0 commented Mar 3, 2026

Thanks for the input @Divyansh013 @lirenjie95 !

@Theresa-Em could you update the PR to remove the english titles and headings please? Thanks so much!

@Theresa-Em
Copy link
Contributor Author

Hi @ksen0 @lirenjie95 @Divyansh013, Thank you all for the clear guidance! I completely agree that keeping only Chinese titles provides a cleaner and more consistent experience. I have updated the file to remove all English portions from the headings and titles. Ready for another look!

@ksen0 ksen0 merged commit 25384f0 into processing:main Mar 3, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants