Fix p5.sound reference source links to point to correct GitHub repo (2.x) #1075
+9
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
Author
|
I’ve added screenshots below to demonstrate the expected behavior after the fix. The “Edit this file” link on p5.sound reference pages now correctly resolves to the processing/p5.sound.js repository (main branch) and no longer returns 404s. Please let me know if any additional verification is needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes incorrect source links on p5.sound reference pages that were pointing to the p5.js repository and resulting in 404 errors.
Details
p5.soundmoduleprocessing/p5.sound.jsrepositorymainbranch for p5.sound and versioned tags for p5.jsResult
Source links on p5.sound reference pages now correctly resolve to valid GitHub files instead of returning 404 errors.
Fixes #1030