Replace X button with dropdown menu in CollectionItemRow#4078
Open
Nixxx19 wants to merge 2 commits intoprocessing:developfrom
Open
Replace X button with dropdown menu in CollectionItemRow#4078Nixxx19 wants to merge 2 commits intoprocessing:developfrom
Nixxx19 wants to merge 2 commits intoprocessing:developfrom
Conversation
Collaborator
|
Thanks so much for the quick turnaround on this! I think the changes here overall look awesome! I think the only suggested changes I have here are UI-based:
Please let me know if you have any other thoughts on this as well! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
Fixes #3883
Fixes #3881
The "X" button in the Collection sketch list view was confusing — it wasn't clear whether it removed the sketch from the collection or deleted it entirely. This PR replaces it with a dropdown menu consistent with the rest of the editor's UI (e.g., My Sketches, My Collections pages).
Demo:
After: A dropdown menu (▾) matching the style used on the My Sketches and My Collections pages, with a "Remove sketch from collection" option.
Changes:
RemoveIconbutton andTooltipwithTableDropdownandMenuItemcomponents inCollectionItemRow.jsxSketchlistDropdownColumnstyled component for consistent positioning with other table dropdownsoverflow: hiddenfrom.collection-containerand.collection-contentto prevent the dropdown from being clipped.collection-row__action-columnand.collection-row__remove-buttonstyles from_collection.scssI have verified that this pull request:
npm run lint)npm run test)npm run typecheck)developbranch.Fixes #123