Migrated from JSHint to ESLint#3836
Migrated from JSHint to ESLint#3836khanniie merged 2 commits intoprocessing:develop-codemirror-v6from
Conversation
|
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. |
|
Hi! Thank you so much for the contribution! If this is regarding the codemirror 5 to 6 migration, the subissue we published was actually regarding the js linter used within the Editor/stateUtils.js file. I do think the approach is correct, it would be great if you could move the changes to that file! |
Nishthajain7
force-pushed
the
migarte-to-eslint
branch
from
5006ef4 to
8955370
Compare
|
Sorry for the delay. There were a lot of emails, and this one slipped through. I've moved the changes to |
|
Hi Nishthajain7! I checked out the branch and it doesn't build properly -- it looks like |
|
The changes to package.json got lost when I discarded the old changes and force-pushed the new ones. I made the changes now |
Nishthajain7
force-pushed
the
migarte-to-eslint
branch
from
8955370 to
f62f52b
Compare
|
Hi! Thanks for updating the package.json. I just checked out the branch but unfortunately it doesn't build for me. I get a It also looks like we wouldn't need to go through the trouble of parsing the message responses and could just pass the linter in directly, if you reference the example code linked above. Could you make the following changes? Thank you! |
Nishthajain7
force-pushed
the
migarte-to-eslint
branch
from
f62f52b to
57c7e7c
Compare
|
@khanniie Thank you for your guidance and suggestions. I've made the requested changes and now it looks much more simpler. I have tested the build as well and it works. Sorry for the inconvinience caused. |
khanniie
left a comment
khanniie
left a comment
There was a problem hiding this comment.
I left a couple of tiny comments but overall this looks and feels great! Thank you so much for accommodating all my requests!
|
|
||
| return diagnostics; | ||
| }; | ||
| function makeJsLinter(callback) { |
There was a problem hiding this comment.
maybe we can just move line 199 to line 207? Since it looks like the callback is no longer necessary anyways!
|
|
||
| import p5JavaScript from './p5JavaScript'; | ||
| import { esLint } from '@codemirror/lang-javascript'; | ||
| import { Linter } from 'eslint-linter-browserify'; |
There was a problem hiding this comment.
let's import as import {Linter as ESLinter}!
|
Thanks so much @khanniie for the review! Just wanted to check in @Nishthajain7 for the follow up changes! |
Nishthajain7
force-pushed
the
migarte-to-eslint
branch
from
57c7e7c to
bac3fbe
Compare
|
I have made the suggested changes |
|
Yay, thank you so much!!! |
3 participants
Fixes #1540
Changes: Updated the preprocessing lint step to use ESLint instead of JSHint.
I have verified that this pull request:
npm run lint)npm run test)npm run typecheck)developbranch.Fixes #123