fix: DR-8251 Update copy for pricing banner#7829
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughRemoved the previous mid-page “Have questions about Pricing?” CTA from Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@apps/site/src/app/pricing/page.tsx`:
- Around line 33-35: The mailto link used for the custom pricing CTA is missing
the recipient address; update the href string in the pricing page component (the
JSX element using href={"mailto:?subject=Prisma%20Custom%20Pricing&body=..."})
to include the proper recipient (e.g. sales@prisma.io) so it becomes
mailto:sales@prisma.io?subject=...; locate the href on the pricing page
(apps/site/src/app/pricing/page.tsx) and insert the recipient email into that
href string exactly where the mailto: scheme is declared.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: e0308911-62f1-4759-9816-2d372b6c5ebd
📒 Files selected for processing (1)
apps/site/src/app/pricing/page.tsx
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@apps/site/src/app/pricing/page.tsx`:
- Line 34: The mailto href in apps/site/src/app/pricing/page.tsx currently
hardcodes personal addresses ("mailto:boch@prisma.io?cc=neubauer@prisma.io...");
update that href to use a role-based alias (e.g., sales@prisma.io or
pricing@prisma.io), remove the cc parameter, and preserve the existing
subject/body query parameters. Locate the mailto string used as the CTA href in
the pricing page component and replace "boch@prisma.io?cc=neubauer@prisma.io"
with "sales@prisma.io" (or another agreed team inbox) so the href becomes
"mailto:sales@prisma.io?subject=...&body=...".
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 90a1a9e9-d0cf-46fd-95c6-170cfb17cb8f
📒 Files selected for processing (1)
apps/site/src/app/pricing/page.tsx
ee3b7e7 to
b507f7c
Compare
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
apps/site/src/app/pricing/pricing-page-content.tsx (1)
30-32: Extract themailto:URL construction from JSX for safer copy edits.The long encoded string on Lines 30-32 is hard to review and easy to break during future copy updates. Build it from params in a constant so text and encoding stay maintainable.
Suggested refactor
export function PricingPageContent() { const [currency, setCurrency] = React.useState<Symbol>("USD"); + const contactHref = `mailto:sales@prisma.io?${new URLSearchParams({ + subject: "Prisma Custom Pricing", + body: `Hi, + +Evaluating Prisma at scale — interested in custom pricing. + +Company: +Expected scale (queries / DBs / etc): + +Thanks`, + }).toString()}`; return ( @@ - href={ - "mailto:boch@prisma.io?cc=neubauer@prisma.io&subject=Prisma%20Custom%20Pricing&body=Hi%2C%0A%0AEvaluating%20Prisma%20at%20scale%20%E2%80%94%20interested%20in%20custom%20pricing.%0A%0ACompany%3A%20%0AExpected%20scale%20(queries%20%2F%20DBs%20%2F%20etc)%3A%0A%0AThanks" - } + href={contactHref}🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@apps/site/src/app/pricing/pricing-page-content.tsx` around lines 30 - 32, The inline mailto URL in the JSX is too long and fragile; extract its construction into a constant (e.g., const mailtoLink or a helper function buildMailtoLink) in pricing-page-content.tsx and have the href reference that constant instead of the raw string. Build the link from discrete params (to, cc, subject, body) and use encodeURIComponent for each value so future copy edits are readable and safe; then replace the current href={"..."} with href={mailtoLink} (or href={buildMailtoLink(params)}).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@apps/site/src/app/pricing/pricing-page-content.tsx`:
- Line 35: The arrow icon <i className="fa-regular fa-arrow-right" /> is
announced by assistive tech and should be marked decorative; update the JSX for
that element in pricing-page-content (the <i className="fa-regular
fa-arrow-right" /> node) to include aria-hidden="true" so screen readers skip
it, ensuring no change to visual rendering or className.
- Around line 30-32: The CTA mailto URL in the JSX (the href string in
PricingPageContent) currently hardcodes individual emails ("boch@prisma.io" and
CC "neubauer@prisma.io"); update that href to use a team-owned shared alias
(e.g., "custom-pricing@prisma.io" or "sales@prisma.io") for the recipient and
any CCs instead of personal addresses, ensuring the mailto query parameters
(subject/body) remain intact and URLs are properly encoded.
---
Nitpick comments:
In `@apps/site/src/app/pricing/pricing-page-content.tsx`:
- Around line 30-32: The inline mailto URL in the JSX is too long and fragile;
extract its construction into a constant (e.g., const mailtoLink or a helper
function buildMailtoLink) in pricing-page-content.tsx and have the href
reference that constant instead of the raw string. Build the link from discrete
params (to, cc, subject, body) and use encodeURIComponent for each value so
future copy edits are readable and safe; then replace the current href={"..."}
with href={mailtoLink} (or href={buildMailtoLink(params)}).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 2c33e835-601b-432c-8c39-0bd05ae98289
📒 Files selected for processing (2)
apps/site/src/app/pricing/page.tsxapps/site/src/app/pricing/pricing-page-content.tsx
💤 Files with no reviewable changes (1)
- apps/site/src/app/pricing/page.tsx
Fixes #DR-8251
Summary by CodeRabbit