fix(ui): keep readable text contrast on Discard edits hover#1503
Open
AmanVarshney01 wants to merge 1 commit intomainfrom
Open
fix(ui): keep readable text contrast on Discard edits hover#1503AmanVarshney01 wants to merge 1 commit intomainfrom
AmanVarshney01 wants to merge 1 commit intomainfrom
Conversation
The "Discard edits" button used `variant="outline"`, which injects `hover:text-accent-foreground`. The local className overrode the hover background (`hover:bg-amber-200`) but not the hover text color, so on hover the text turned the light accent-foreground color over an amber background, producing poor contrast. Drop `variant="outline"` (default variant has no hover text-color rule) and add `border` to the className. This matches the sibling "Save edits" button's pattern. Text now stays `text-amber-950` in both default and hover states.
|
Compute preview deployed. Branch: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
variant="outline"injectedhover:text-accent-foreground, which the local className didn't override — text turned light over amber on hover. Dropped the variant and addedborderexplicitly to match the sibling Save edits button.Before
after