fix(ui): truncate overflowing SelectTrigger value#1502
Open
AmanVarshney01 wants to merge 1 commit intomainfrom
Open
fix(ui): truncate overflowing SelectTrigger value#1502AmanVarshney01 wants to merge 1 commit intomainfrom
AmanVarshney01 wants to merge 1 commit intomainfrom
Conversation
The Schema selector in the sidebar overflowed for long schema names (e.g. `_prisma_dev_wal`), pushing the chevron out of view. Two compounding causes inside `SelectTrigger`: - Adding the `label` prop wrapped the value in an extra `<div>`, so the existing `[&>span]:line-clamp-1` rule no longer matched the value span. - That wrapper `<div>` had no width constraint, so its content could grow past the trigger's bounds. Flatten the trigger to render `label`, value, and chevron as direct flex children. The label and chevron stay `shrink-0`; the value gets `flex-1 min-w-0 truncate text-left` so long values ellipsize cleanly while the chevron stays anchored on the right.
|
Compute preview deployed. Branch: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Schema selector overflowed for long names — chevron got pushed out. Flattened the trigger so the value gets
flex-1 min-w-0 truncateand ellipsizes cleanly.Before
After
