fix mysql introspection json columns#1495
Open
aiprojectchiwa wants to merge 1 commit intoprisma:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix MySQL/MariaDB introspection in Prisma Studio when the introspection query returns aggregated
columnsas a JSON string instead of an array.This prevents Studio from crashing with errors like:
a.sort is not a functioncolumns.sort is not a functionRoot cause
Some MySQL-compatible backends (notably MariaDB variants) can return the
json_arrayagg(...)result as a string payload. The adapter assumedcolumnswas always already an array and called.sort()directly.Fix
columnsbefore sortingVerification
Validated on Node
24.13.0with:pnpm typecheckpnpm exec eslint data/mysql-core/adapter.ts data/mysql-core/introspection-hardening.test.tspnpm test:datapnpm buildpnpm check:exports