Handover brief for the e2e coverage work - #199
Conversation
Self-contained enough to hand to someone with no access to this worktree: what the convention is and why this repo owes it, what is merged and open, the four problems left with their exact error strings, the next task with the fixture entry points, and the environment gotchas — the e2e token, the turbo test race, the signing flag. Ends with the mistake worth inheriting: a json-mode test was cited as proof that a human-mode call was safe, and json mode never makes that call. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Signed-off-by: willbot <w.a.madden+machine@gmail.com> Signed-off-by: Will Madden <madden@prisma.io>
|
Warning Review limit reached
Next review available in: 42 minutes Limit details: You’ve used all 1 included review currently available under your plan. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
1 participant
A brief for whoever picks this up next, written to be self-contained — someone with no access to my worktree and none of the conversation should be able to act on it.
It covers what the coverage convention is and why this repo owes it rather than the repos that own the commands; what is merged and what is open; the four problems left, with the exact error strings so they are recognisable; the next task (
service deployment rollback) with the fixture entry points that already exist; and the environment gotchas that cost me time — the e2e token's deliberately different name, the turbo test race that looks like mass breakage, and the signing flag needed in an agent shell.It ends with the mistake worth inheriting. I reported that requiring
stdoutat runtime was safe and cited a passing test as evidence; that test ran in json mode, and json mode never callsstdout. Human mode would have exited 2 across eighteen ORM commands. The three habits that come out of it — a run in one format proves nothing about the other, a test that cannot fail proves nothing, and rebuild before trusting a test — are worth more than any single test in this series.Document only.