Skip to content

test: remove case-colliding ActionList snapshots - #8660

Open
joshblack wants to merge 2 commits into
mainfrom
fix/actionlist-snapshot-case-collisions
Open

joshblack wants to merge 2 commits into
mainfrom
fix/actionlist-snapshot-case-collisions

Conversation

@joshblack

@joshblack joshblack commented Nov 2, 2026 •

Copy link
Copy Markdown
Member

Closes #

Remove 27 duplicate ActionList snapshots whose filenames differ from the retained baselines only by lowercase with versus uppercase With. These paths collide on case-insensitive filesystems, causing jj to report deleted files immediately after initialization.

Keep the uppercase With baselines and update the three corresponding titles in e2e/components/ActionList.test.ts to match. The duplicate image pairs are byte-for-byte identical, so this does not change visual coverage or component behavior.

Changelog

New

Changed

  • Update the three ActionList VRT titles to use uppercase With.

Removed

  • Remove 27 duplicate lowercase-with ActionList snapshot baselines.

Rollout strategy

  • None

Verified that all 27 uppercase baselines are retained unchanged and that no case-insensitive tracked path collisions remain. npx playwright test e2e/components/ActionList.test.ts --list --grep '(Group Heading With Classname|Heading With Classname|Visuals With Classnames)' passes and collects all 27 matching cases. VRT image comparisons were not run.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: b534c2a7-9591-46e2-88ef-17c074b936a4
@joshblack joshblack added the skip changeset This change does not need a changelog label Nov 2, 2026
Copilot AI balanced review requested due to automatic review settings November 2, 2026 16:00
@joshblack
joshblack requested a review from a team as a code owner November 2, 2026 16:00
@changeset-bot

changeset-bot Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 5721ae8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@joshblack
joshblack requested a review from TylerJDev November 2, 2026 16:00

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request. Check if the Files changed in this pull request are included in default exclusions.

@github-actions github-actions Bot added the staff Author is a staff member label Nov 2, 2026
@joshblack joshblack added the integration-tests: skipped manually Changes in this PR do not require an integration test label Nov 2, 2026
@joshblack
joshblack enabled auto-merge November 2, 2026 16:14
@github-actions
github-actions Bot temporarily deployed to storybook-preview-8660 November 2, 2026 16:15 Inactive
@joshblack
joshblack disabled auto-merge November 2, 2026 16:15
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: b534c2a7-9591-46e2-88ef-17c074b936a4

This branch was successfully deployed

2 active deployments
storybook-preview-8660 — 5721ae8e Deployed Nov 2, 2026 by github-actions[bot]
github-pages — 5721ae8e Deployed Nov 2, 2026 by joshblack via deploy-preview #34000
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: skipped manually Changes in this PR do not require an integration test skip changeset This change does not need a changelog staff Author is a staff member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants