Repository navigation
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: b534c2a7-9591-46e2-88ef-17c074b936a4
|
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request. Check if the Files changed in this pull request are included in default exclusions.
joshblack
enabled auto-merge
November 2, 2026 16:14
liuliu-dev
approved these changes
Nov 2, 2026
joshblack
disabled auto-merge
November 2, 2026 16:15
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: b534c2a7-9591-46e2-88ef-17c074b936a4
joshblack
enabled auto-merge
November 2, 2026 16:23
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #
Remove 27 duplicate ActionList snapshots whose filenames differ from the retained baselines only by lowercase
withversus uppercaseWith. These paths collide on case-insensitive filesystems, causing jj to report deleted files immediately after initialization.Keep the uppercase
Withbaselines and update the three corresponding titles ine2e/components/ActionList.test.tsto match. The duplicate image pairs are byte-for-byte identical, so this does not change visual coverage or component behavior.Changelog
New
Changed
With.Removed
withActionList snapshot baselines.Rollout strategy
Verified that all 27 uppercase baselines are retained unchanged and that no case-insensitive tracked path collisions remain.
npx playwright test e2e/components/ActionList.test.ts --list --grep '(Group Heading With Classname|Heading With Classname|Visuals With Classnames)'passes and collects all 27 matching cases. VRT image comparisons were not run.