Repository navigation
Conversation
🦋 Changeset detectedLatest commit: ad1f80b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The disabled Select arrow stays in the enabled system color in forced-colors mode. Both existing fill values are quoted CSS strings, and the disabled selector looks for an SVG inside the select even though the arrow is its next sibling.
Use valid FieldText and GrayText keywords and target the sibling arrow for the disabled state. Includes a patch changeset.
Changelog
Changed
Rollout strategy
Testing & Reviewing
Review the Default and Disabled Select stories with forced colors active. The enabled arrow should use FieldText and the disabled arrow should use GrayText.