Skip to content

Select: fix dropdown arrow colors in forced-colors mode - #8658

Open
wBaob wants to merge 1 commit into
primer:mainfrom
wBaob:fix/select-forced-colors-arrow
Open

wBaob wants to merge 1 commit into
primer:mainfrom
wBaob:fix/select-forced-colors-arrow

Conversation

@wBaob

@wBaob wBaob commented Nov 1, 2026

Copy link
Copy Markdown

The disabled Select arrow stays in the enabled system color in forced-colors mode. Both existing fill values are quoted CSS strings, and the disabled selector looks for an SVG inside the select even though the arrow is its next sibling.

Use valid FieldText and GrayText keywords and target the sibling arrow for the disabled state. Includes a patch changeset.

Changelog

Changed

  • Use the appropriate system color for enabled and disabled Select arrows in forced-colors mode.

Rollout strategy

  • Not sure (open-source contributor)

Testing & Reviewing

  • Two Playwright checks cover enabled and disabled Select stories with forced colors emulated. The disabled check fails on main and both pass with the fix.
  • The Select component suite passes (11 tests).
  • Package and root TypeScript checks, scoped ESLint and Stylelint, Prettier, and git diff --check pass.
  • Local browser checks used the existing Chromium installation through an uncommitted runner config.

Review the Default and Disabled Select stories with forced colors active. The enabled arrow should use FieldText and the disabled arrow should use GrayText.

@wBaob
wBaob requested a review from a team as a code owner November 1, 2026 17:04
Copilot AI balanced review requested due to automatic review settings November 1, 2026 17:04
@changeset-bot

changeset-bot Bot commented Nov 1, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: ad1f80b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@wBaob
wBaob requested review from siddharthkp and removed request for Copilot November 1, 2026 17:04

This branch had an error being deployed

1 failed deployment
github-pages — ad1f80b2 Deployed Nov 1, 2026 by wBaob via deploy-preview #30295
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant