Repository navigation
UnderlineNav: respect prefers-reduced-motion for the loading counter - #8656
Open
RafaelHDSV wants to merge 1 commit into
Open
RafaelHDSV wants to merge 1 commit into
RafaelHDSV wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: edc15c8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8651
The loading-counter pulse on UnderlineNav / TabNav ran for as long as the count was fetching, with no
prefers-reduced-motionguard. The same “something is coming” treatment onSkeletonBox,ProgressBar, andSegmentedControlalready opts in to motion.The counter still renders as a solid grey pill. The 1.2s opacity animation only runs when the visitor has not asked for reduced motion.
Changelog
New
n/a
Changed
LoadingCounter(UnderlineNav / TabNav): wrap the pulse animation in@media (prefers-reduced-motion: no-preference)Removed
n/a
Rollout strategy
Testing & Reviewing
loadingCounters(or TabNav in a loading-count state).prefers-reduced-motion: reduce.animation-nameshould benone.no-preference: the pulse should still run (loadingCounterKeyFrames).Visual snapshots should be unchanged: the reduced-motion end state is the same fully opaque pill the animation starts from.