Skip to content

Use Storybook test builds for VRT and AAT#8222

Open
joshblack with Copilot wants to merge 2 commits into
mainfrom
copilot/use-test-option-storybook-builds
Open

Use Storybook test builds for VRT and AAT#8222
joshblack with Copilot wants to merge 2 commits into
mainfrom
copilot/use-test-option-storybook-builds

Conversation

Copilot AI commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Pass Storybook’s --test option through Turborepo for VRT, snapshot-update, and AAT builds. Local builds were 15% faster while retaining all 1,169 stories.

Changelog

New

  • None.

Changed

  • Build VRT and AAT Storybooks with --test.

Removed

  • None.

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; CI-only change.

Testing & Reviewing

Build Mean duration
Current 137.57s
--test 116.91s
  • Two forced local runs per mode.
  • Both modes produced the same 1,169 story entries.

Co-authored-by: joshblack <3901764+joshblack@users.noreply.github.com>
@changeset-bot

changeset-bot Bot commented Jul 22, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 3a62b78

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copilot AI requested a review from joshblack July 22, 2026 21:33
@github-actions
github-actions Bot temporarily deployed to storybook-preview-8222 July 22, 2026 21:56 Inactive
@joshblack joshblack added skip changeset This change does not need a changelog integration-tests: skipped manually Changes in this PR do not require an integration test labels Jul 22, 2026
@joshblack
joshblack marked this pull request as ready for review July 22, 2026 22:07
@joshblack
joshblack requested a review from a team as a code owner July 22, 2026 22:07
@joshblack
joshblack requested review from Copilot and jonrohan July 22, 2026 22:07

@jonrohan jonrohan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, shaved off about a minute, but probably not a lot of slow plugins involved like dotcom

@joshblack
joshblack enabled auto-merge July 22, 2026 22:09

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the CI workflows used for VRT and AAT Storybook builds to pass Storybook’s --test flag through Turborepo, aiming to speed up these builds while keeping the same set of stories.

Changes:

  • Pass --test to turbo run build:storybook in the VRT workflow.
  • Pass --test to turbo run build:storybook in the VRT reports workflow.
  • Pass --test to turbo run build:storybook in the AAT reports workflow.
Show a summary per file
File Description
.github/workflows/vrt.yml Adds --test passthrough to the Storybook build step used by the VRT snapshot-update path.
.github/workflows/vrt-reports.yml Adds --test passthrough to the Storybook build step used by the VRT report runner.
.github/workflows/aat-reports.yml Adds --test passthrough to the Storybook build step used by the AAT report runner.

Review details

  • Files reviewed: 3/3 changed files
  • Comments generated: 3
  • Review effort level: Low

Comment thread .github/workflows/vrt.yml Outdated
Comment on lines +53 to +54
- name: Build storybook
run: npx turbo run build:storybook
run: npx turbo run build:storybook -- --test
Comment thread .github/workflows/vrt-reports.yml Outdated
Comment on lines +37 to +38
- name: Build storybook
run: npx turbo run build:storybook
run: npx turbo run build:storybook -- --test
Comment thread .github/workflows/aat-reports.yml Outdated
Comment on lines +37 to +38
- name: Build storybook
run: npx turbo run build:storybook
run: npx turbo run build:storybook -- --test
@joshblack

Copy link
Copy Markdown
Member

@copilot apply review feedback

Co-authored-by: joshblack <3901764+joshblack@users.noreply.github.com>
auto-merge was automatically disabled July 23, 2026 15:23

Head branch was pushed to by a user without write access

Copilot AI commented Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

@copilot apply review feedback

Applied the review feedback in 3a62b78. The workflow build steps now filter turbo run build:storybook to only the Storybooks each job serves, so --test no longer gets forwarded to the root docs build script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: skipped manually Changes in this PR do not require an integration test skip changeset This change does not need a changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants