Timeline: tag Secret Scanning event stories with taxonomy data-* attributes#8220
Closed
janmaarten-a11y wants to merge 1 commit into
Closed
Timeline: tag Secret Scanning event stories with taxonomy data-* attributes#8220janmaarten-a11y wants to merge 1 commit into
janmaarten-a11y wants to merge 1 commit into
Conversation
…ibutes Spread the shared event data-* contract onto the cataloged Secret Scanning Timeline.Item rows, projected from SECRET_SCANNING_TAXONOMY via toEventDataAttributes. Storybook-only, no visual change. Variants with no catalog leaf are left untagged with an explanatory comment.
|
Contributor
Author
|
Closing: consolidating the four Timeline surface-tagging changes into one combined PR. Branch janmaarten-a11y-timeline-tag-secret-scanning-stories stays intact at 91cf463 for integration. |
primer
Bot
deleted the
janmaarten-a11y-timeline-tag-secret-scanning-stories
branch
July 23, 2026 00:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the Phase 3 taxonomy tagging fan-out (github/primer#6664, epic github/primer#6654), following the License Compliance pilot (#8216). This is Storybook-only and produces no visual change.
It tags the Secret Scanning Timeline event stories with the same event
data-*contract as the LC pilot, projected from the merged taxonomy module (#8180) and documented in github/primer#6888. A smallsecretScanningAttrs(type, login)helper reads category and visibility fromSECRET_SCANNING_TAXONOMYand resolves the actor viaactorTypeForLogin, then spreads the result onto each catalogedTimeline.Item.The Secret Scanning catalog was scoped to the five live event-switch cases (seven leaves) and is narrower than the shipped story set, so many variants have no catalog leaf. Those are intentionally left untagged, each with an inline comment.
Per-row attributes
Each tagged row carries
data-event-scope="secret-scanning",data-event-type(the unscoped leaf),data-event-categoryanddata-event-visibility(from the catalog), anddata-actor-type(from the rendered actor login, omitted when no actor).Tagged leaves:
detected(findings). Renders the GitHub system-identity actor.closed; the "Reopened" section's leading closed context row alsoclosed; "Reopened" toreopened.bypassed.validity_changed(automated rows render the GitHub system actor, manual rows a user actor).dismissal_requested; "Dismissal approved" and "Dismissal denied" todismissal_reviewed.Intentionally left untagged (no catalog leaf, or parked/shared)
Flagged judgment calls for review
data-actor-type="user"becauseactorTypeForLogin('GitHub')returnsuser(GitHub is not in the bot set). Whether a system identity should classify as user vs bot is worth confirming.Changelog
Changed
data-*attributes on cataloged event rows (Storybook-only).Rollout strategy
Testing & Reviewing
Ran prettier, eslint, and type-check (all pass). Rendered the stories headlessly and confirmed: EventCreated to
data-event-scope="secret-scanning"data-event-type="detected"data-event-category="findings"data-actor-type="user"; an EventResolution "Closed as ..." row todata-event-type="closed"; an EventClosureRequest approved row todata-event-type="dismissal_reviewed"; sixvalidity_changedrows; and that EventReport, EventMetadata, EventAssignment, the two delegated Bypass rows, and the Dismissal-cancelled row carry nodata-event-*attributes. Zero console errors.