Skip to content

Blankslate: shift size scale and use default button size - #8034

Open
dylanatsmith with Copilot wants to merge 12 commits into
mainfrom
copilot/update-blankslate-styles
Open

dylanatsmith with Copilot wants to merge 12 commits into
mainfrom
copilot/update-blankslate-styles

Conversation

Copilot AI commented Jun 23, 2026 •

Copy link
Copy Markdown
Contributor

Rescales Blankslate sizes so the compact styling is the default. The old small styles become the default medium, the old medium styles become large, and the old large styles are removed. The primary action button now uses the default (medium) size at every Blankslate size.

Related PR

Companion change: primer/view_components#4110 — Blankslate: make compact styling the default.

Both PRs make the compact Blankslate presentation the default so the component stays visually consistent across our React and Rails/ViewComponents implementations. view_components has no size prop, BlankslateContext, or small/medium/large scale, so the portable part of this change there is simply promoting the compact styling to the base rules and dropping the now-redundant @container responsive block. They should land together to avoid the two implementations drifting apart.

Changelog

New

Changed

  • size="medium" (default) now renders the former small styling; size="large" renders the former medium styling.
  • Blankslate.PrimaryAction always renders a default-size button instead of a small button on the compact size.
  • Updated stories, docs metadata, Figma connect, and padding test to match the new scale.

Removed

  • size="small" value and the former large styles.
  • Redundant @container responsive block (the compact presentation it produced is now the default).
  • Now-unused Blankslate size context (BlankslateContext), which only existed to drive the conditional button size.

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Migration: size no longer accepts "small". Consumers using size="small" should drop the prop (default medium now matches the old small visuals). Consumers relying on the old medium/large visuals should bump up one step (medium → large); the old large has no replacement.

Testing & Reviewing

  • Verify the Default, SizeMedium, and SizeLarge stories render the expected padding/typography.
  • Confirm primary action buttons render at the default size for both medium and large.

Merge checklist

…um become large

Co-authored-by: dylanatsmith <6905903+dylanatsmith@users.noreply.github.com>
@changeset-bot

changeset-bot Bot commented Jun 23, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: accc25a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@primer/react Major
@primer/mcp Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@@ -0,0 +1,5 @@
---
'@primer/react': major

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’d argue this could be a minor version but it is sort of a breaking change so 🤷‍♂️

@github-actions github-actions Bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Jun 23, 2026
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Action required

👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. If this doesn't work, you can also use the original workflow here. Check the integration testing docs for step-by-step instructions. Or, apply the integration-tests: skipped manually label to skip these checks.

To publish a canary release for integration testing, apply the Canary Release label to this PR.

Co-authored-by: dylanatsmith <6905903+dylanatsmith@users.noreply.github.com>
Copilot AI changed the title Shift Blankslate size scale: default to the compact (former small) styles Blankslate: shift size scale and use default button size Jun 23, 2026
Copilot AI requested a review from dylanatsmith June 23, 2026 14:04
@github-actions
github-actions Bot temporarily deployed to storybook-preview-8034 June 23, 2026 14:05 Inactive
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions github-actions Bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Jun 23, 2026
@github-actions
github-actions Bot temporarily deployed to storybook-preview-8034 June 23, 2026 19:47 Inactive
@github-actions
github-actions Bot temporarily deployed to storybook-preview-8034 June 23, 2026 19:56 Inactive
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

@llastflowers llastflowers left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Please add to this issue as a candidate for next major release: https://github.com/github/primer/issues/5430

@dylanatsmith

Copy link
Copy Markdown
Member

@liuliu-dev @llastflowers Is this waiting on anything? I don't have merge permissions for this repo.

@github-actions

Copy link
Copy Markdown
Contributor

Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days.

@github-actions github-actions Bot added the Stale label Oct 13, 2026
@github-actions github-actions Bot closed this Oct 20, 2026
@github-actions
github-actions Bot deleted the copilot/update-blankslate-styles branch October 20, 2026 11:12
@lesliecdubs
lesliecdubs restored the copilot/update-blankslate-styles branch October 26, 2026 14:22
@lesliecdubs lesliecdubs reopened this Oct 26, 2026
@lesliecdubs

Copy link
Copy Markdown
Member

@liuliu-dev this one has been sitting approved for a long time, can we get it into this week's release please?

@github-actions github-actions Bot removed the Stale label Oct 26, 2026
@github-actions
github-actions Bot requested a deployment to storybook-preview-8034 October 27, 2026 02:09 Abandoned
@github-actions
github-actions Bot temporarily deployed to storybook-preview-8034 October 27, 2026 02:18 Inactive
@github-actions
github-actions Bot temporarily deployed to storybook-preview-8034 November 2, 2026 19:18 Inactive
@francinelucca francinelucca added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Nov 2, 2026
@primer-integration

primer-integration Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Integration test results from github/github-ui PR:

Running  Changes   Running
Failed  CI   Failed
Waiting  VRT   Waiting
Waiting  Projects   Waiting

CI check runs linting, type checking, and unit tests. Check the workflow logs for specific failures.

Need help? If you believe this failure is unrelated to your changes, please reach out to the Primer team for assistance.

@github-actions github-actions Bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Nov 3, 2026

This branch was successfully deployed

2 active deployments
storybook-preview-8034 — accc25ad Deployed Nov 3, 2026 by github-actions[bot]
github-pages — accc25ad Deployed Nov 3, 2026 by primer[bot] via deploy-preview #34002
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

design-polish integration-tests: failing Changes in this PR cause breaking changes in gh/gh

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants