ActionList: Support mixed descriptions#7919
Draft
obvioussean wants to merge 1 commit into
Draft
Conversation
Allow an item to render one inline description beside the label and one block description below the label. This lets consumers add a secondary detail line without rebuilding ActionList item layout by hand.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
🦋 Changeset detectedLatest commit: 89b6c1b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs github/github-ui#22256
Adds first-class ActionList support for rendering one inline description beside an item label and one block description beneath the same label. This gives consumers a supported way to add a second detail line, such as estimated cost, without hand-rolling label and description styling inside
ActionList.Itemchildren.Changelog
New
ActionList.Itemsupports rendering one inlineActionList.Descriptionand one blockActionList.Descriptiontogether.Changed
Removed
Rollout strategy
Testing & Reviewing
Validated the new mixed-description path with:
npm run buildnpm run type-checknpm run lintnpm run lint:cssnpm run format:diffnpm test -- packages/react/src/ActionList/ActionList.test.tsxcomponents-actionlist-features--inline-and-block-descriptionI also ran the full
npm test; it failed on an unrelated localAnchoredOverlayclick timeout after the ActionList suite passed.Merge checklist