Skip to content

Conversation

@TylerJDev
Copy link
Member

@TylerJDev TylerJDev commented Oct 21, 2025

Closes: https://github.com/github/primer/issues/4723

Reverts the reverted PR: #6986

Original PR authored by @khiga8

Changelog

  • Ensure that the tooltip is keyboard-accessible even when the control is disabled. This is important since all SegmentedControl.IconButton will show a tooltip by default, and we want this to be accessible for keyboard users even when the control is disabled.
  • Reverts revert PR (Revert "Clean up the feature flag for primer_react_segmented_control_tooltip" #6412)
    • When we first tried to ship our cleanup of primer_react_segmented_control_tooltip, 1 integration test failed in dotcom. This is because a tooltip was now being applied on a disabled control, causing the <Tooltip> component to thrown an area. This will be resolved by the aforementioned change.

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Merge checklist

@changeset-bot
Copy link

changeset-bot bot commented Oct 21, 2025

🦋 Changeset detected

Latest commit: 9d52fb7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Oct 21, 2025
@github-actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot temporarily deployed to storybook-preview-7047 October 21, 2025 15:48 Inactive
@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Oct 21, 2025
@github-actions github-actions bot temporarily deployed to storybook-preview-7047 October 21, 2025 16:07 Inactive
@github-actions github-actions bot removed the integration-tests: failing Changes in this PR cause breaking changes in gh/gh label Oct 21, 2025
@github-actions github-actions bot temporarily deployed to storybook-preview-7047 December 1, 2025 15:07 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2025

👋 Hi, there are new commits since the last successful integration test. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Or, apply the integration-tests: skipped manually label to skip these checks.

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Dec 1, 2025
@TylerJDev TylerJDev added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Dec 1, 2025
@github-actions github-actions bot removed the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Dec 1, 2025
@github-actions github-actions bot temporarily deployed to storybook-preview-7047 December 1, 2025 15:22 Inactive
@primer-integration
Copy link

👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/7787

@primer primer bot requested a review from a team as a code owner December 1, 2025 15:30
@primer primer bot requested a review from mperrotti December 1, 2025 15:30
@github-actions github-actions bot added integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm and removed update snapshots 🤖 Command that updates VRT snapshots on the pull request labels Dec 1, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2025

👋 Hi, there are new commits since the last successful integration test. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Or, apply the integration-tests: skipped manually label to skip these checks.

@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh labels Dec 1, 2025
@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: failing Changes in this PR cause breaking changes in gh/gh labels Dec 1, 2025
@primer-integration
Copy link

🟢 ci completed with status success.

@TylerJDev TylerJDev added this pull request to the merge queue Dec 1, 2025
Merged via the queue into main with commit c07dd71 Dec 1, 2025
50 checks passed
@TylerJDev TylerJDev deleted the kh-segmented-control branch December 1, 2025 16:17
@primer primer bot mentioned this pull request Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants