-
Notifications
You must be signed in to change notification settings - Fork 647
[a11y] When aria-disabled is set on SegmentedControl, don't allow action #7047
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…t_segmented_control_tooltip`" This reverts commit 602b29a.
…stories.tsx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Tyler Jones <tylerjdev@github.com>
🦋 Changeset detectedLatest commit: 9d52fb7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
|
👋 Hi, there are new commits since the last successful integration test. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Or, apply the |
|
👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/7787 |
|
👋 Hi, there are new commits since the last successful integration test. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Or, apply the |
|
🟢 ci completed with status |
Closes: https://github.com/github/primer/issues/4723
Reverts the reverted PR: #6986
Original PR authored by @khiga8
Changelog
SegmentedControl.IconButtonwill show a tooltip by default, and we want this to be accessible for keyboard users even when the control is disabled.primer_react_segmented_control_tooltip" #6412)primer_react_segmented_control_tooltip, 1 integration test failed in dotcom. This is because a tooltip was now being applied on adisabledcontrol, causing the<Tooltip>component to thrown an area. This will be resolved by the aforementioned change.Rollout strategy
Merge checklist