fix: keep & on foreach targets that are not plain variables

src/printer.mjs

@@ -2063,6 +2063,11 @@ function printNode(path, options, print) {
     }
     case "foreach": {
       const body = printBodyControlStructure(path, options, print, "body");
+      // Only a plain variable prints its own &
+      const value =
+        node.value.byref && node.value.kind !== "variable"
+          ? ["&", print("value")]
+          : print("value");
 
       // We want to keep dangling comments above the loop to stay consistent.
       // Any comment positioned between the for statement and the parentheses
@@ -2086,8 +2091,8 @@ function printNode(path, options, print) {
               "as ",
               group(
                 node.key
-                  ? indent(join([" =>", line], [print("key"), print("value")]))
-                  : print("value")
+                  ? indent(join([" =>", line], [print("key"), value]))
+                  : value
               ),
             ]),
             softline,

tests/foreach/__snapshots__/jsfmt.spec.mjs.snap

@@ -72,6 +72,12 @@ foreach ($test as &$i) {
     $test2 = $i;
 }
 
+foreach ($test as &$object->property) {
+}
+
+foreach ($test as $key => &$array[$key]) {
+}
+
 =====================================output=====================================
 <?php
 foreach ($test as $i) {
@@ -170,5 +176,11 @@ foreach ($test as &$i) {
     $test2 = $i;
 }
 
+foreach ($test as &$object->property) {
+}
+
+foreach ($test as $key => &$array[$key]) {
+}
+
 ================================================================================
 `;

tests/foreach/foreach.php

@@ -63,3 +63,9 @@
 foreach ($test as &$i) {
     $test2 = $i;
 }
+
+foreach ($test as &$object->property) {
+}
+
+foreach ($test as $key => &$array[$key]) {
+}