Fix failed offline checkins with signed data (Z#23223233)#71
Merged
Conversation
checkIfItemIsInList needed to be given the local item id, but for pretix_sig1 secrets, checkOfflineWithoutData was using the server id. Now all calls have to pass the server_id and checkIfItemIsInList does the join.
raphaelm
reviewed
Feb 18, 2026
libpretixsync/src/main/sqldelight/common/eu/pretix/libpretixsync/sqldelight/CheckInList.sq
Outdated
Show resolved
Hide resolved
pajowu
force-pushed
the
pajowu/fix_offline_sig1
branch
from
1704062 to
4692b1f
Compare
pajowu
force-pushed
the
pajowu/fix_offline_sig1
branch
from
4692b1f to
0ad7a58
Compare
robbi5
approved these changes
Feb 18, 2026
raphaelm
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
checkIfItemIsInListneeded to be given the local item id, but for pretix_sig1 secrets, it was using the server id. Now all calls have to pass the server id andcheckIfItemIsInListdoes theJOIN.