Conversation
Member
Author
|
Actually, since now every component uses its own list of arguments (and might be called from arbitrary repositories), I needed to add a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be able to work with PRs from forks, the
COMPONENT_PR(e.g.,PRECICE_PR) is being passed by the calling workflow. Since this is not a required argument, it was not declared as one incomponents.yaml.#907 changed the build argument parsing from "forward everything the user defines" to "collect whatever each component needs". This ignores the extra arguments. While this is better from a security point of view, it reduces the flexibility that was useful in this case.
As a workaround, this PR sets for each
COMPONENTaCOMPONENT_PRargument, with an empty string as a default value. Testing without calling from a workflow one does not seem to complain. TheTUTORIALS_PRis set in thebarecomponent, as this is the base for everything else.This should enable working with forks again, which was detected in the context of precice/precice#2601.