New adapter: BeOp#4476
Open
przemkaczmarek wants to merge 1 commit intomasterfrom
Open
Conversation
CTMBNara
requested changes
Apr 27, 2026
Comment on lines
+49
to
+51
| if (CollectionUtils.isEmpty(imps)) { | ||
| return Result.withError(BidderError.badInput("No impressions provided")); | ||
| } |
Comment on lines
+145
to
+148
| if (mtype == null) { | ||
| throw new PreBidException( | ||
| "Failed to parse bid mtype for impression \"%s\"".formatted(bid.getImpid())); | ||
| } |
Collaborator
There was a problem hiding this comment.
Replace with switch branch:
case null, default -> ...
Comment on lines
+11
to
+18
| String beopPublisherId; | ||
|
|
||
| @JsonProperty("nid") | ||
| String beopNetworkId; | ||
|
|
||
| @JsonProperty("nptnid") | ||
| @JsonAlias("ntpnid") | ||
| String beopNetworkPartnerId; |
Collaborator
There was a problem hiding this comment.
Rename to publisherId, networkId and networkPartnerId. Remove @JsonAlias. Fix @JsonProperty to use ntpnid
Comment on lines
+10
to
+12
| app-media-types: | ||
| - banner | ||
| - video |
Collaborator
There was a problem hiding this comment.
app isn't declared in GO
Comment on lines
+15
to
+18
| "nptnid": { | ||
| "type": "string", | ||
| "description": "Network partner ID" | ||
| }, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
#4416