Skip to content

Housekeeping: Fix flaky Gpp test #4474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
osulzhenko wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −4
Open

Housekeeping: Fix flaky Gpp test #4474

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/test/groovy/org/prebid/server/functional/tests/privacy/GppCookieSyncSpec.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,11 +385,11 @@ class GppCookieSyncSpec extends BaseSpec {
]
}

def "PBS shouldn't emit error message when request doesn't contain gdpr config and global skip gdpr config for adapter"() {
def "PBS should allow sync without error when GPP SID is not excluded and GDPR is out of scope"() {
given: "Default CookieSyncRequest with gdpr config"
def gppSid = TCF_EU_V2
def gppSidExcludeSkipValues = PBSUtils.getRandomEnum(GppSectionId.class, [FIRST_GPP_SECTION, SECOND_GPP_SECTION])
def cookieSyncRequest = CookieSyncRequest.defaultCookieSyncRequest.tap {
it.gppSid = gppSid.intValue
it.gppSid = gppSidExcludeSkipValues.intValue
it.gdpr = 0
it.gdprConsent = new TcfConsent.Builder().build()
}
Expand All @@ -400,7 +400,7 @@ class GppCookieSyncSpec extends BaseSpec {
then: "Response userSync url should contain cookies and userSync"
def bidderStatus = response.getBidderUserSync(GENERIC)
assert HttpUtil.findUrlParameterValue(bidderStatus.userSync?.url, "gpp") == ""
assert HttpUtil.findUrlParameterValue(bidderStatus.userSync?.url, "gpp_sid") == gppSid.value
assert HttpUtil.findUrlParameterValue(bidderStatus.userSync?.url, "gpp_sid") == gppSidExcludeSkipValues.value

and: "Response shouldn't contains any error"
assert !bidderStatus.error
Expand Down
Loading