Core: EID Permissions extension #4349
Open
+350
−64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And1sS
requested changes
Jan 12, 2026
src/main/java/org/prebid/server/auction/model/EidPermissionIndex.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/auction/model/EidPermissionIndex.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/auction/model/EidPermissionIndex.java
Outdated
Show resolved
Hide resolved
Net-burst
force-pushed
the
feature/extend-eid-permissions
branch
from
f174bd6 to
9a711eb
Compare
# Conflicts: # src/test/java/org/prebid/server/auction/ExchangeServiceTest.java
CTMBNara
requested changes
Jan 15, 2026
Comment on lines
+61
to
+64
| return (eidPermission.getInserter() == null || eidPermission.getInserter().equals(eid.getInserter())) | ||
| && (eidPermission.getSource() == null || eidPermission.getSource().equals(eid.getSource())) | ||
| && (eidPermission.getMatcher() == null || eidPermission.getMatcher().equals(eid.getMatcher())) | ||
| && (eidPermission.getMm() == null || eidPermission.getMm().equals(eid.getMm())); |
Collaborator
There was a problem hiding this comment.
add method nullOrEquals(T permission, T eid)
Comment on lines
+39
to
+42
| @Deprecated | ||
| public static ExtRequestPrebidDataEidPermissions of(String source, List<String> bidders) { | ||
| return new ExtRequestPrebidDataEidPermissions(null, source, null, null, bidders); | ||
| } |
Collaborator
There was a problem hiding this comment.
I don't like the idea to keep it
| List<String> warnings) throws ValidationException { | ||
|
|
||
| if (eidPermissions == null) { | ||
| if (ObjectUtils.isEmpty(eidPermissions)) { |
| validateEidPermissionCriteria(eidPermission.getInserter(), | ||
| eidPermission.getSource(), | ||
| eidPermission.getMatcher(), | ||
| eidPermission.getMm()); |
Collaborator
There was a problem hiding this comment.
validateEidPermissionCriteria(
eidPermission.getInserter(),
eidPermission.getSource(),
eidPermission.getMatcher(),
eidPermission.getMm());
| String source, | ||
| String matcher, | ||
| Integer mm) throws ValidationException { | ||
| if (StringUtils.isEmpty(inserter) |
Collaborator
There was a problem hiding this comment.
Add empty line after multi-line declaration
| if (StringUtils.isEmpty(inserter) | ||
| && StringUtils.isEmpty(source) | ||
| && StringUtils.isEmpty(matcher) | ||
| && mm == null) { |
Collaborator
There was a problem hiding this comment.
What about to use StringUtils.isAllEmpty?
And1sS
requested changes
Jan 15, 2026
Comment on lines
+2247
to
+2390
| public void shouldFilterUserExtEidsWhenBidderIsNotAllowedForInserterIgnoringCase() { | ||
| testUserEidsPermissionFiltering( | ||
| // given | ||
| asList(Eid.builder().inserter("inserter1").build(), Eid.builder().inserter("inserter2").build()), | ||
| singletonList(ExtRequestPrebidDataEidPermissions.builder() | ||
| .inserter("inserter1") | ||
| .bidders(singletonList("OtHeRbIdDeR")) | ||
| .build()), | ||
| emptyMap(), | ||
| // expected | ||
| singletonList(Eid.builder().inserter("inserter2").build())); | ||
| } | ||
|
|
||
| @Test | ||
| public void shouldFilterUserExtEidsWhenBidderIsNotAllowedForMatcherIgnoringCase() { | ||
| testUserEidsPermissionFiltering( | ||
| // given | ||
| asList(Eid.builder().matcher("matcher1").build(), Eid.builder().matcher("matcher2").build()), | ||
| singletonList(ExtRequestPrebidDataEidPermissions.builder() | ||
| .matcher("matcher1") | ||
| .bidders(singletonList("OtHeRbIdDeR")) | ||
| .build()), | ||
| emptyMap(), | ||
| // expected | ||
| singletonList(Eid.builder().matcher("matcher2").build())); | ||
| } | ||
|
|
||
| @Test | ||
| public void shouldFilterUserExtEidsWhenBidderIsNotAllowedForMm() { | ||
| testUserEidsPermissionFiltering( | ||
| // given | ||
| asList(Eid.builder().mm(1).build(), Eid.builder().mm(2).build()), | ||
| singletonList(ExtRequestPrebidDataEidPermissions.builder() | ||
| .mm(1) | ||
| .bidders(singletonList("OtHeRbIdDeR")) | ||
| .build()), | ||
| emptyMap(), | ||
| // expected | ||
| singletonList(Eid.builder().mm(2).build())); | ||
| } | ||
|
|
||
| @Test | ||
| public void shouldFilterUserExtEidsWhenBidderIsNotAllowedUsingMultipleCriteria() { | ||
| testUserEidsPermissionFiltering( | ||
| // given | ||
| asList(Eid.builder().inserter("inserter1").source("source1").matcher("matcher1").mm(1).build(), | ||
| Eid.builder().inserter("inserter2").source("source2").matcher("matcher2").mm(2).build()), | ||
| singletonList(ExtRequestPrebidDataEidPermissions.builder() | ||
| .inserter("inserter1") | ||
| .source("source1") | ||
| .matcher("matcher1") | ||
| .mm(1) | ||
| .bidders(singletonList("OtHeRbIdDeR")) | ||
| .build()), | ||
| emptyMap(), | ||
| // expected | ||
| singletonList(Eid.builder().inserter("inserter2").source("source2").matcher("matcher2").mm(2).build())); | ||
| } | ||
|
|
||
| @Test | ||
| public void shouldFilterUserExtEidsWhenEveryCriteriaMatches() { | ||
| testUserEidsPermissionFiltering( | ||
| // given | ||
| asList(Eid.builder().inserter("inserter1").source("source1").matcher("matcher1").mm(1).build(), | ||
| Eid.builder().inserter("inserter2").source("source2").matcher("matcher2").mm(2).build()), | ||
| singletonList(ExtRequestPrebidDataEidPermissions.builder() | ||
| .inserter("inserter1") | ||
| .source("source2") | ||
| .matcher("matcher3") | ||
| .mm(4) | ||
| .bidders(singletonList("OtHeRbIdDeR")) | ||
| .build()), | ||
| emptyMap(), | ||
| // expected | ||
| asList(Eid.builder().inserter("inserter1").source("source1").matcher("matcher1").mm(1).build(), | ||
| Eid.builder().inserter("inserter2").source("source2").matcher("matcher2").mm(2).build())); | ||
| } | ||
|
|
||
| @Test | ||
| public void shouldFilterUserExtEidsWhenBidderIsNotAllowedUsingTheMostSpecificRule() { | ||
| testUserEidsPermissionFiltering( | ||
| // given | ||
| asList(Eid.builder().inserter("inserter1").source("source1").matcher("matcher1").mm(1).build(), | ||
| Eid.builder().inserter("inserter2").source("source2").matcher("matcher2").mm(2).build()), | ||
| asList(ExtRequestPrebidDataEidPermissions.builder() | ||
| .inserter("inserter1") | ||
| .bidders(singletonList("someBidder")) | ||
| .build(), | ||
| ExtRequestPrebidDataEidPermissions.builder() | ||
| .inserter("inserter1") | ||
| .source("source1") | ||
| .matcher("matcher1") | ||
| .mm(1) | ||
| .bidders(singletonList("OtHeRbIdDeR")) | ||
| .build()), | ||
| emptyMap(), | ||
| // expected | ||
| singletonList(Eid.builder().inserter("inserter2").source("source2").matcher("matcher2").mm(2).build())); | ||
| } | ||
|
|
||
| @Test | ||
| public void shouldNotFilterUserExtEidsWhenBidderIsAllowedUsingTheMostSpecificRule() { | ||
| testUserEidsPermissionFiltering( | ||
| // given | ||
| asList(Eid.builder().inserter("inserter1").source("source1").matcher("matcher1").mm(1).build(), | ||
| Eid.builder().inserter("inserter2").source("source2").matcher("matcher2").mm(2).build()), | ||
| asList(ExtRequestPrebidDataEidPermissions.builder() | ||
| .inserter("inserter1") | ||
| .bidders(singletonList("OtHeRbIdDeR")) | ||
| .build(), | ||
| ExtRequestPrebidDataEidPermissions.builder() | ||
| .inserter("inserter1") | ||
| .source("source1") | ||
| .matcher("matcher1") | ||
| .mm(1) | ||
| .bidders(singletonList("someBidder")) | ||
| .build()), | ||
| emptyMap(), | ||
| // expected | ||
| asList(Eid.builder().inserter("inserter1").source("source1").matcher("matcher1").mm(1).build(), | ||
| Eid.builder().inserter("inserter2").source("source2").matcher("matcher2").mm(2).build())); | ||
| } | ||
|
|
||
| @Test | ||
| public void shouldNotFilterUserExtEidsWhenBidderIsAllowedUsingMultipleSameSpecificityRules() { | ||
| testUserEidsPermissionFiltering( | ||
| // given | ||
| asList(Eid.builder().inserter("inserter1").source("source1").matcher("matcher1").mm(1).build(), | ||
| Eid.builder().inserter("inserter2").source("source2").matcher("matcher2").mm(2).build()), | ||
| asList(ExtRequestPrebidDataEidPermissions.builder() | ||
| .inserter("inserter1") | ||
| .source("source1") | ||
| .bidders(singletonList("OtHeRbIdDeR")) | ||
| .build(), | ||
| ExtRequestPrebidDataEidPermissions.builder() | ||
| .matcher("matcher1") | ||
| .mm(1) | ||
| .bidders(singletonList("someBidder")) | ||
| .build()), | ||
| emptyMap(), | ||
| // expected | ||
| asList(Eid.builder().inserter("inserter1").source("source1").matcher("matcher1").mm(1).build(), | ||
| Eid.builder().inserter("inserter2").source("source2").matcher("matcher2").mm(2).build())); | ||
| } |
Collaborator
There was a problem hiding this comment.
Since you have extracted logic from ExchangeService -> tests should be moved too. Also, please, unwrap tests. This is unreadable.
Comment on lines
+670
to
675
| private List<Eid> resolveAllowedEids(List<Eid> userEids, String bidder, EidPermissionHolder eidPermissionHolder) { | ||
| return CollectionUtils.emptyIfNull(userEids) | ||
| .stream() | ||
| .filter(userEid -> isUserEidAllowed(userEid.getSource(), eidPermissions, bidder)) | ||
| .filter(userEid -> eidPermissionHolder.isAllowed(userEid, bidder)) | ||
| .toList(); | ||
| } |
Collaborator
There was a problem hiding this comment.
Can also be moved to EidPermissionHolder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
prebid/prebid-server#4623