Repository navigation
fix(identify): classify named pipes - #621
Closed
awais-ur-rehman wants to merge 1 commit into
Closed
awais-ur-rehman wants to merge 1 commit into
awais-ur-rehman wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Running
identify-clion a named pipe with no writer blocks when identification tries to read the path. Use the mode fromlstatto return thefifotag before inspecting contents, as identification already does for sockets and symlinks.This addresses the named-pipe part of #72. The socket part was handled in #177.
Breaking Changes
None. Named pipes now return the
fifotype tag.Testing
mkfifo test-pipeand thenidentify-cli test-pipe. The command should immediately print["fifo"]without a writer.coverage run -m pytest testsandcoverage reportwith thelicenseextra and test dependencies installed. All 554 tests passed on Python 3.11 and 3.14.pre-commit run --all-files --show-diff-on-failure.Codex assisted with the reproduction, patch, and tests.