Repository navigation
CI green: PHP 8.2 prado harness, IBM DB2, SQL Server and Firebird suites - #1
Merged
belisoful merged 1 commit intoOct 22, 2026
Merged
Conversation
Install / harness - composer.json: dev platform PHP 8.2 (pradosoft/prado dev-master requires 8.2); autoload prado's namespaced test harness (Prado\Test\Unit\) from vendor. - phpunit bootstrap / BaseCase: use Prado\Test\Unit\Harness\TTestApplication and Prado\Test\Unit\PradoUnit (PradoUnitRequires.php no longer exists). - BaseCase: include the underlying exception in the schema-init failure; close the config connection between classes. TActiveRecordManager kept the previous class's pdo_firebird connection open, and its implicit transaction blocked the next class's DROP TABLE forever (the Firebird job hang). SqlMap (src) - TPreparedCommand: bind NULL as PDO::PARAM_STR on pdo_ibm (PARAM_NULL is rejected); bind PHP bools as 0/1 on pdo_firebird (bools bind only to BOOLEAN columns). - TMappedStatement: drop the PRADO_ROWNUM helper column that TIbmCommandBuilder's ROW_NUMBER() paging subquery returns. Test maps / configs - mssql Category.xml: insert-null-params binds GuidString; InsertCategoryNull is an <insert> with a post selectKey; GetCategory aliases GuidString. - IbmScriptRunner strips "--" comments before splitting on ";". - IbmBaseTestConfig: PDO::ATTR_CASE CASE_NATURAL (pdo_ibm defaults to CASE_UPPER). - Firebird maps: quote reserved-word aliases (value, Date, Day, Month, datetime) and hashtable aliases; CAST nullable delete parameters. - ActiveAccount COLUMN_MAPPING: uppercase Firebird column names. - IBM ActiveRecord save test skips until Prado\Data\TDbDriverCapabilities (untyped binding for pdo_ibm) is available in prado. Workflow - PHP matrix 8.2-8.5, actions/checkout@v7, actions/cache@v6, Firebird step timeout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Install / harness
SqlMap (src)
Test maps / configs
Workflow