Repository navigation
Conversation
GET /api/v1/commitfests/<cfid>/patches now returns each patch's threads unconditionally, so the ?include=threads parameter is removed. Unknown query parameters are ignored, so existing callers passing it keep working.
kjrocker
force-pushed
the
api-patches-always-threads
branch
from
October 27, 2026 16:05
d09cc29 to
8f5876f
Compare
Contributor
Author
|
Closing this myself. With the param deployed this more of a breaking change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My previous PR (#115) added optional threads on each //patches endpoint,
behind a query parameter. (?include=threads).
In hindsight, adding parameters is a slippery slope, and since it's a single
additional query I'd rather just add the threads to each patch always.