Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #199.
Attribute selectors such as
[href=]currently parse without an error and stringify as[href], silently dropping the operator. Require a value whenever an attribute operator is present, using the parser's existing error path. Quoted empty values such as[href=""]remain valid.The regression tests cover all six attribute operators, whitespace, comments, namespaces, synchronous and asynchronous APIs, and PostCSS error locations. On the original code, 16 expected-error tests fail while 13 valid-input controls pass; all 29 pass with the fix.
Validation:
npm testpasses all 926 tests, including lint, type checking, the build and coverage thresholds. Changed files pass formatting. The full formatting command reports the same two unchanged upstream files (exceptions.mjsandpseudos.mjs) on both the original and patched trees.AI assistance was used to develop and review this change.