docs: credit remaining dependencies, remove internal policy from NOTICE - #7
Open
jonyoder wants to merge 1 commit into
Open
docs: credit remaining dependencies, remove internal policy from NOTICE#7jonyoder wants to merge 1 commit into
jonyoder wants to merge 1 commit into
Conversation
Three SHOULD-FIX items from the attribution audit. Every substantive claim in this NOTICE was verified accurate and the chain of title is clean, so this is housekeeping rather than a correction. 1. Defused a latent trap. "No source from those projects is incorporated at this time" is currently TRUE here, because the resolver is unimplemented -- but it becomes false the moment candidate/, provider/, or resolver/ is written, since uv-resolver is the expected reference for that work and reading it is permitted in this module. A sentence of exactly this form went stale unnoticed in go-python-packaging, contradicted by material added the next day and surviving thirteen later edits to the same file because every one of them appended at the end instead of revisiting the top. The paragraph now carries an explicit instruction to delete it, and says why. 2. Removed internal development policy. A NOTICE is a legal attribution artifact; a citation to a private RFD and an imperative about what to read while working on a DIFFERENT module do not belong in one, and shipping a private document reference in a public file is its own small problem. The content is unchanged in CLAUDE.md, which is where a contributor looks for it. 3. Credited two dependencies the NOTICE omitted: rstudio/repository-snapshot-format and posit-dev/go-python-packaging, the latter pointing at its own NOTICE for the upstreams it in turn credits. Refs the attribution audit at ~/Dev/attribution-audit-2026-08-04.md Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Three SHOULD-FIX items from the attribution audit. Every substantive claim in this NOTICE was verified accurate and the chain of title is clean (
pypi-manifest→ PPM → here, all Posit-copyrighted), so the audit's verdict is that this module is redistributable as-is. This is housekeeping, not a correction.Contrast with the sibling: go-python-packaging needed three MUST-FIX items (posit-dev/go-python-packaging#19).
1. Defused a latent trap before it fires
"No source from those projects is incorporated at this time" is currently true here, because the resolver is unimplemented. But it becomes false the moment
candidate/,provider/, orresolver/is written —uv-resolveris the expected reference for that work, and reading it is explicitly permitted in this module.That matters because a sentence of exactly this form already went stale unnoticed next door: contradicted by material added the following day, then surviving thirteen later edits to the same file, because every one of them appended at the end instead of revisiting the top. The paragraph now carries an explicit instruction to delete it, and says why, so the next person to touch
candidate/sees it.2. Removed internal development policy from a legal artifact
A NOTICE exists to attribute copyright. A citation to a private RFD, plus an imperative about what to read while working on a different module, don't belong in one — and shipping a private-document reference in a public file is its own small problem.
The content is unchanged in
CLAUDE.md, which is where a contributor actually looks for it.3. Credited two omitted dependencies
rstudio/repository-snapshot-formatandposit-dev/go-python-packaging, the latter pointing at its own NOTICE for the upstreams it in turn credits.Verification
Build and tests pass. Not merging — licensing text wants your eyes.
🤖 Generated with Claude Code