Repository navigation
Conversation
| /// Constant channels from layer parameters, scale-bypassing (e.g. | ||
| /// `start_marker`/`end_marker` from the `arrow` SETTING). | ||
| pub constants: Vec<(&'static str, HValue)>, |
There was a problem hiding this comment.
If there is already a pre-existing path parameters should take, we should use that instead.
| // Same rationale as the aggregate check above: surface `arrow` | ||
| // vocabulary errors without executing. | ||
| if let Err(e) = crate::plot::layer::geom::types::validate_arrow_param(&layer.parameters) | ||
| { | ||
| errors.push(ValidationError { | ||
| message: format!("{}: {}", context, e), | ||
| location: None, | ||
| }); | ||
| } |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
I'd actually argue that line-ends should be a proper aesthetic (line-start and line-end separately) |
|
I'm not ideologically opposed to that, that is also what I did in ggarrow. But it needs some discussion around palettes, discrete vs continuous and how it interplays with sizing. |
|
I'm honestly only interested in a |
|
I've made them proper aesthetics now. Current behaviour is best captured in scale/aesthetic/arrow.qmd doc. |
|
Current test failure repeats in main (signal: 11, SIGSEGV: invalid memory reference), so probably this PR isn't to blame. |
This PR aims to fix an entry in #530.
Briefly this allows
SETTING arrow => 'open'in line, path and segment geometries.By default, this sets the end arrow and when using length-2 array e.g.
['open', 'open']it sets the start and end arrows.We take hephaestus arrows, but omit the
arrow-prefix.Arrow size by default is hephaestus' default (3x linewidth), but size can also be set by using a numeric suffix, e.g.
'open:10'.