Skip to content

Fix panel boundary missing for lon/lat map projections#482

Merged
teunbrand merged 1 commit into
posit-dev:mainfrom
teunbrand:fix_lonlat_panel_background
Jun 19, 2026
Merged

Fix panel boundary missing for lon/lat map projections#482
teunbrand merged 1 commit into
posit-dev:mainfrom
teunbrand:fix_lonlat_panel_background

Conversation

@teunbrand

Copy link
Copy Markdown
Collaborator

This PR fixes an issue discussed off-github.

Essentially it ensures that the fallback coordinate system (EPSG:4326, e.g. lonlat) goes through the pipes and triggers the right panel boundary.

When geometries lack an explicit SRID (e.g. bundled parquet datasets),
resolve_epsg_property returned None and the fallback "EPSG:4326" string
was stored directly without PROJ resolution. This left the coord as
UnknownProj, skipping clip boundary and panel background computation.

Add a fallback parameter to resolve_epsg_property so absent properties
go through the same EPSG→PROJ lookup, ensuring the coord rebuilds
correctly as Geographic.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@teunbrand teunbrand requested a review from thomasp85 June 19, 2026 11:09

@thomasp85 thomasp85 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@teunbrand teunbrand merged commit d1f142f into posit-dev:main Jun 19, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants