Fix stacking bug#403
Open
teunbrand wants to merge 1 commit intoposit-dev:mainfrom
Open
Conversation
The sort in apply_stack used [group_col, ...partition_by] as sort keys, but partition_by order is non-deterministic (HashMap iteration). When fill sorted before facet, rows from the same facet panel were interleaved, causing compute_group_ids (which relies on adjacency) to treat every row as its own group — making cumsum a no-op. Fix: build the over/group columns first, use them as primary sort keys, then append remaining partition_by columns after. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #402.
Briefly, the
partition_byis a HashMap, which has non-deterministic order. This made facets land in the wrong place in the sorting hierarchy, which led to treating every row as its own group. The fix is to put facet columns as the outer sorting columns.