Conversation
lionel-
added this pull request to stack #1412
September 18, 2026 18:21
lionel-
force-pushed
the
oak-query/hardening
branch
from
September 20, 2026 09:27
9b615db to
43c7f75
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1409
This PR introduces stronger safety invariants by splitting database access into narrower capabilities:
SourceDbexposes source text, syntax, workspace membership, and package metadata. Recovery fallbacks receive this interface, so they can't call back into semantic queries.ResolverDbwraps the full database but exposes only the three recursive queries the resolver needs: exports, attached packages, and cross-file layers. All three have explicit cycle handlers.Dbmarks unrestricted database access and is required by the remaining semantic queries.This doesn't remove the recursive parts of source resolution, but it makes them explicit and prevents unrelated semantic queries from being reached accidentally.
Positron Release Notes
New Features
Bug Fixes