Conversation
lionel-
added this pull request to stack #1412
September 18, 2026 17:36
lionel-
force-pushed
the
oak-query/guardrails
branch
from
September 20, 2026 09:27
90d7d7c to
8e55fa0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1409
This PR adds review guardrails when the Salsa declaration surface changes: a new query, different key, or changed recovery policy now leaves an explicit snapshot diff that asks the reviewer to reconsider cycle safety. The reviewer is pointed to a new
salsa.mdguide.The snapshots are generated by a new
oak_tidycrate. The name "tidy" follows other projects where "tidying" means checking source-level properties that the type system can't enforce:Oak's Rust source is walked with the
syncrate to find Salsa queries and cycle handlers. The collected data is snapshotted with insta.Note that the snapshot is necessarily partial: it only captures the Salsa declarations, not simple functions calling these queries. It doesn't capture Salsa edges in general because they can arise from any kind of Rust code invocation (methods, closures, functions), and can't be traced in the general case.
In addition to its role in prompting agents for a review when it changes, the snapshot is also a useful reference for both us and agents.