test: pin sidecar-array patch routing for containers and custom arrays#2980
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Contributor
📦 Bundle Stats —
|
| Metric | Value | vs main (4d77522) |
|---|---|---|
| Internal (raw) | 802.3 KB | - |
| Internal (gzip) | 153.7 KB | - |
| Bundled (raw) | 1.41 MB | - |
| Bundled (gzip) | 318.0 KB | - |
| Import time | 75ms | -0ms, -0.3% |
@portabletext/editor/behaviors
| Metric | Value | vs main (4d77522) |
|---|---|---|
| Internal (raw) | 467 B | - |
| Internal (gzip) | 207 B | - |
| Bundled (raw) | 424 B | - |
| Bundled (gzip) | 171 B | - |
| Import time | 2ms | -0ms, -0.3% |
@portabletext/editor/plugins
| Metric | Value | vs main (4d77522) |
|---|---|---|
| Internal (raw) | 2.7 KB | - |
| Internal (gzip) | 894 B | - |
| Bundled (raw) | 2.5 KB | - |
| Bundled (gzip) | 827 B | - |
| Import time | 6ms | +0ms, +1.6% |
@portabletext/editor/selectors
| Metric | Value | vs main (4d77522) |
|---|---|---|
| Internal (raw) | 81.2 KB | - |
| Internal (gzip) | 14.9 KB | - |
| Bundled (raw) | 76.9 KB | - |
| Bundled (gzip) | 13.8 KB | - |
| Import time | 6ms | +0ms, +2.5% |
@portabletext/editor/traversal
| Metric | Value | vs main (4d77522) |
|---|---|---|
| Internal (raw) | 28.1 KB | - |
| Internal (gzip) | 5.6 KB | - |
| Bundled (raw) | 28.1 KB | - |
| Bundled (gzip) | 5.5 KB | - |
| Import time | 5ms | +0ms, +1.3% |
@portabletext/editor/utils
| Metric | Value | vs main (4d77522) |
|---|---|---|
| Internal (raw) | 29.7 KB | - |
| Internal (gzip) | 6.2 KB | - |
| Bundled (raw) | 27.4 KB | - |
| Bundled (gzip) | 5.9 KB | - |
| Import time | 5ms | +0ms, +1.9% |
🗺️ . · ./behaviors · ./plugins · ./selectors · ./traversal · ./utils · Artifacts
Details
- Import time regressions over 10% are flagged with
⚠️ - Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.
📦 Bundle Stats — @portabletext/markdown
Compared against main (4d775222)
| Metric | Value | vs main (4d77522) |
|---|---|---|
| Internal (raw) | 53.8 KB | - |
| Internal (gzip) | 9.8 KB | - |
| Bundled (raw) | 348.9 KB | - |
| Bundled (gzip) | 96.3 KB | - |
| Import time | 31ms | +2ms, +8.6% |
🗺️ View treemap · Artifacts
Details
- Import time regressions over 10% are flagged with
⚠️ - Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.
christianhg
force-pushed
the
test-sidecar-array-patch-coverage
branch
from
July 20, 2026 06:50
214c374 to
685901c
Compare
christianhg
force-pushed
the
test-sidecar-array-patch-coverage
branch
from
July 20, 2026 06:53
685901c to
6d0e943
Compare
christianhg
force-pushed
the
test-sidecar-array-patch-coverage
branch
from
July 20, 2026 06:54
6d0e943 to
d06e8e0
Compare
christianhg
force-pushed
the
test-sidecar-array-patch-coverage
branch
from
July 20, 2026 06:57
d06e8e0 to
893b2e6
Compare
The sidecar-array suite covered `marks`/`markDefs` on root-level text blocks only. Extend it with the shapes the routing must also handle: `marks` and `markDefs` on container-nested blocks (one and two container depths, where the root block the data patch applies on is the container and the block-relative path descends field-generically), a custom array on a void block object, and a container-owned data array sitting beside the container's structural child field. All pass against the shipped implementation; they exist to hold as the regression net when the classifier/fallback machinery is replaced by field-generic handlers.
christianhg
force-pushed
the
test-sidecar-array-patch-coverage
branch
from
July 20, 2026 07:00
893b2e6 to
d8ce1d3
Compare
christianhg
marked this pull request as ready for review
July 20, 2026 07:03
christianhg
enabled auto-merge (rebase)
July 20, 2026 07:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test-only follow-up to #2974. Its suite pins
marks/markDefsrouting on root-level text blocks; during review the container-nested case was verified by a throwaway probe, and the "does this hold for arrays that aren'tmarks?" question wasn't pinned at all. This promotes both into the repo.Five new scenarios in
event.patches.sidecar-arrays.test.tsx, all passing against the shipped implementation unchanged:marksinsert on a container-nested span, and an annotation toggle (marks+markDefsinserts) on a container-nested block, the case where the "root block" the data patch applies on is the container itself and the block-relative path descends field-generically.marksunset two containers deep (table > row > cell > block > span).image.tags[-1]), a sidecar array that isn'tmarks/markDefs.callout.tags[0]) sitting beside the container's structural child field (content), pinning that the classifier distinguishes the two arrays on the same node.Beyond documenting the shipped contract, these are the regression net for the planned replacement of the classifier/fallback machinery with field-generic handlers (tracked separately as a follow-up): tests that predate that refactor and pin today's observable behavior. No production code changes, no changeset.