Skip to content

Visor: keep the strip above Android Chrome's bottom controls - #184

Merged
lannbot merged 1 commit into
mainfrom
fix/android-visor-height
Sep 8, 2026
Merged

Visor: keep the strip above Android Chrome's bottom controls#184
lannbot merged 1 commit into
mainfrom
fix/android-visor-height

Conversation

@lannbot

@lannbot lannbot commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Size the drawer with svh, the stable viewport with browser toolbars visible, instead of vh.
  • Cap the drawer to reserve the 56px strip plus 96px below it, including short landscape screens.
  • Size the page with 100dvh so the app area follows the currently available viewport.

Verification

  • Astra review completed.
  • just check, workspace Rust tests and Deno tests passed.
  • Full Chromium suite passed: 29 scenarios, including a new mobile-context test at 390x844, 360x640, 320x480 and 844x390.
  • Regression checks cover viewport-unit rules, strip and app-area geometry, no shell overflow, and scrolling the final control into view.
  • Physical Android toolbar verification was not available; Playwright does not emulate toolbar expansion/collapse.

Automerge will be armed.

@lannbot
lannbot enabled auto-merge September 8, 2026 12:06
@lannbot
lannbot merged commit 1bb0adb into main Sep 8, 2026
2 checks passed
@lannbot
lannbot deleted the fix/android-visor-height branch September 8, 2026 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants