Install: static framework icons at https: URLs, not client-painted blobs - #181
Merged
Conversation
Android installs are WebAPKs, minted by a server that fetches the manifest's icons by URL; a blob: icon is unreachable to it and the install degrades to "Add to Home screen". So the icons are the framework's own PNGs on the home origin, and the glyph-on-hue icon — and the `glyph` field of install-request — go. This is also the probe for the next question: whether that server re-fetches the manifest itself, which decides whether a blob: manifest can ever install on Android or a service worker has to serve one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Android installs are WebAPKs, minted by a server that fetches the
manifest's icons by URL; a blob: icon is unreachable to it and the
install degrades to "Add to Home screen". So the icons are the
framework's own PNGs on the home origin, and the glyph-on-hue icon —
and the
glyphfield of install-request — go. This is also the probefor the next question: whether that server re-fetches the manifest
itself, which decides whether a blob: manifest can ever install on
Android or a service worker has to serve one.
Gates:
just ci,just e2e22/22. Automerge armed.