fix: make main authoritative for HyperMeow - #35
Conversation
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
purpshell
changed the title
|
@codex review exact head f646ee794e5614e3af70fecba54d6ee0f21f4e77. Verify the self-retraction strategy, main-only pseudo-version policy, README cleanup, unchanged test inventory/coverage, and benchmark artifact moves. Ignore prior-head verdicts. |
|
Correction: review exact current head f646ee7. The prior comment mistyped the expansion; ignore it. |
|
@codex review exact current head 09c6eb2. Final README footer now follows Polymorfa Cellar's support/sponsor/disclaimer structure, credits Tulir Asokan and Rajeh Taher, and removes repository-layout sections. Also verify prior retraction, business.go consolidation, API/test/coverage preservation, and artifact moves. Ignore prior heads. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 09c6eb29a9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
9d9623c to
d5611d1
Compare
|
@codex review exact head d5611d1. Ignore prior heads. Audit the corrected full-history licensing boundary: inherited upstream files remain MPL-2.0, including removed historical util/cbcutil/cbc_test.go; 42 Polymorfa-authored Go files and other commentable Polymorfa files use the Rajeh Taher MIT header. Verify LICENSE-MIT, LICENSING.md, generated bindings, SQL migrations, retained tests, and README claims. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d5611d1eac
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
d5611d1 to
4f93059
Compare
|
@codex review exact head 4f93059. Ignore every prior head. Verify the resolved findings: both benchmark Dockerfiles now carry Rajeh Taher MIT notices after their syntax directives; README preserves upstream file-level copyright years; installation uses @main; v0.0.0 is the sole planned selectable tag while v0.1.0/v0.1.1 remain retracted. Re-audit the complete MPL/MIT boundary and preservation proofs. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4f930592bf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
4f93059 to
5bb05b3
Compare
|
@codex review exact head 5bb05b3. Ignore prior heads. Re-audit the complete content-lineage MPL/MIT boundary. In particular, util/cbcutil/cbc_test.go is Rajeh-authored MIT: be55f11 introduced entirely new short-write tests after an unrelated upstream encrypt/decrypt test at that path had been deleted. Verify all prior versioning, Docker, README attribution, preservation, and licensing fixes remain correct. |
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5bb05b3882
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| go mod edit -dropreplace=go.mau.fi/whatsmeow | ||
| go get github.com/polymorfa/hypermeow@main | ||
| go mod tidy |
There was a problem hiding this comment.
When a transitive dependency still imports go.mau.fi/whatsmeow, these commands leave that module in the graph, so the resulting binary links both generated protobuf packages and panics during initialization when they register identical descriptor paths. The compatibility note in CHANGELOG.md lines 82–83 confirms that the modules cannot coexist; retain a graph check such as the previously documented go list -deps -test/go mod why -m step instead of presenting go mod tidy as a complete migration.
Useful? React with 👍 / 👎.
1 participant
Summary
v0.1.0and the requiredv0.1.1retraction carrier@mainfor the newest reviewed pseudo-version;v0.0.0remains the only selectable tagdevas an integration branch that never publishes or indexes versionsbusiness.gobenchmark/barback/testdata/resultsLicensing boundary
tulir/whatsmeowhistory retain MPL-2.0LICENSE-MITandLICENSING.mdbusiness.goretains Tulir Asokan copyright and MPL-2.0Version correction
Go proxies cannot discover an untagged pseudo-version through
@latestwhen every tagged version is retracted. After this PR is approved and merge-committed tomain, createv0.1.1on this exact reviewed PR head as the self-retracted correction carrier and createv0.0.0on the reviewedmainmerge commit as the only selectable tag. Do not create a GitHub Release.@latestthen resolvesv0.0.0;@mainresolves the newest reviewed main commit to its pseudo-version.Preservation proofs
mainmain(2,288 / 40,324)Verification
pre-commit run --all-filesgo build ./...go test ./...go test -race ./...benchmark_legacy, and race suitesMerge policy
Draft until exact-head review is clean. Do not bypass the
mainruleset. After required human approval and a merge commit, create only thev0.0.0selectable tag and self-retractedv0.1.1carrier described above, verify proxy resolution, then fast-forwarddevto authoritativemain.